Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1503)

Issue 15729008: [OSX] ConstrainedWindow with "proper" background color. (Closed)

Created:
7 years, 7 months ago by groby-ooo-7-16
Modified:
7 years, 6 months ago
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

ConstrainedWindow with "proper" background color. ConstrainedWindow used to have clearColor as backgroundColor - which means all underlying views had to assume that the background color was chrome_style::GetBackgroundColor instead of just querying the window. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202645

Patch Set 1 #

Patch Set 2 : Alternate version: Window Server draws background, NSView draws transparency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_window.mm View 1 3 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
groby-ooo-7-16
Hi Sailesh! Per our e-mail thread on background color, this would be an alternative version ...
7 years, 7 months ago (2013-05-25 03:01:51 UTC) #1
sail
lgtm
7 years, 7 months ago (2013-05-25 13:05:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/15729008/2001
7 years, 6 months ago (2013-05-28 18:18:08 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-05-28 18:49:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/15729008/2001
7 years, 6 months ago (2013-05-28 19:10:05 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-05-28 20:39:34 UTC) #6
Message was sent while issue was closed.
Change committed as 202645

Powered by Google App Engine
This is Rietveld 408576698