Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15729007: Cleanup: Remove fileapi::FileSystemMountPointProvider::InitializeCopyOrMoveFileValidatorFactory() a… (Closed)

Created:
7 years, 7 months ago by Lei Zhang
Modified:
7 years, 6 months ago
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, vandebo (ex-Chrome)
Visibility:
Public.

Description

Cleanup: Remove fileapi::FileSystemMountPointProvider::InitializeCopyOrMoveFileValidatorFactory() and make it a method only in TestMountPointProvider. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202827

Patch Set 1 : #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -61 lines) Patch
M chrome/browser/media_galleries/fileapi/media_file_system_mount_point_provider.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_system_mount_point_provider.cc View 1 1 chunk +0 lines, -15 lines 0 comments Download
M webkit/browser/chromeos/fileapi/cros_mount_point_provider.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/browser/chromeos/fileapi/cros_mount_point_provider.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M webkit/browser/fileapi/copy_or_move_file_validator_unittest.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M webkit/browser/fileapi/file_system_mount_point_provider.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M webkit/browser/fileapi/isolated_mount_point_provider.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/isolated_mount_point_provider.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M webkit/browser/fileapi/sandbox_mount_point_provider.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/sandbox_mount_point_provider.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M webkit/browser/fileapi/test_mount_point_provider.h View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/test_mount_point_provider.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Lei Zhang
Will any non-test implementation ever have a useful InitializeCopyOrMoveFileValidatorFactory() method? If not, let's remove it. ...
7 years, 6 months ago (2013-05-28 20:46:21 UTC) #1
kinuko
Great, lgtm https://codereview.chromium.org/15729007/diff/17001/webkit/browser/fileapi/test_mount_point_provider.h File webkit/browser/fileapi/test_mount_point_provider.h (right): https://codereview.chromium.org/15729007/diff/17001/webkit/browser/fileapi/test_mount_point_provider.h#newcode77 webkit/browser/fileapi/test_mount_point_provider.h:77: scoped_ptr<CopyOrMoveFileValidatorFactory> factory); nit: does this need to ...
7 years, 6 months ago (2013-05-29 01:35:21 UTC) #2
Lei Zhang
https://codereview.chromium.org/15729007/diff/17001/webkit/browser/fileapi/test_mount_point_provider.h File webkit/browser/fileapi/test_mount_point_provider.h (right): https://codereview.chromium.org/15729007/diff/17001/webkit/browser/fileapi/test_mount_point_provider.h#newcode77 webkit/browser/fileapi/test_mount_point_provider.h:77: scoped_ptr<CopyOrMoveFileValidatorFactory> factory); On 2013/05/29 01:35:21, kinuko wrote: > nit: ...
7 years, 6 months ago (2013-05-29 01:37:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/15729007/27001
7 years, 6 months ago (2013-05-29 01:37:36 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=154958
7 years, 6 months ago (2013-05-29 07:33:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/15729007/27001
7 years, 6 months ago (2013-05-29 07:42:43 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 08:51:33 UTC) #7
Message was sent while issue was closed. 
Change committed as 202827

Powered by Google App Engine
This is Rietveld 408576698