Add the 'content' column to see what text is used to detect a language

Add the 'content' column to chrome://translate-internals/

This column allows us to see what text is used to detect a language.  The text is generated from the web page seen by the user, and doesn't include HTML tags.  The text is sent from the renderer process to the browser process each time when detecting.

This feature will help us to solve the problems, for example, the problem where the translation infobar indicates the web page language we don't expect.

For now, with this CL, the text is always sent even though the translate-internals tab page doesn't exist.

BUG=175967
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203093

[hajimehoshi, 2013-05-23 06:35:46]

Can you take a look, please?

[Takashi Toyoshima, 2013-05-23 06:54:53]

lgtm on translate/

https://codereview.chromium.org/15728008/diff/1/chrome/renderer/translate/tra...
File chrome/renderer/translate/translate_helper.cc (right):

https://codereview.chromium.org/15728008/diff/1/chrome/renderer/translate/tra...
chrome/renderer/translate/translate_helper.cc:116: // TODO(hajimehoshi): this
parameter should be set only if
this -> This.

Probably, we can say,
"If this affects performance, it can be set if"...

[hajimehoshi, 2013-05-23 06:59:18]

Thanks!

https://codereview.chromium.org/15728008/diff/1/chrome/renderer/translate/tra...
File chrome/renderer/translate/translate_helper.cc (right):

https://codereview.chromium.org/15728008/diff/1/chrome/renderer/translate/tra...
chrome/renderer/translate/translate_helper.cc:116: // TODO(hajimehoshi): this
parameter should be set only if
On 2013/05/23 06:54:53, Takashi Toyoshima (chromium) wrote:
> this -> This.
> 
> Probably, we can say,
> "If this affects performance, it can be set if"...

Done.

[hajimehoshi, 2013-05-23 07:08:12]

Can you take a look?  Thank you in advance.

On 2013/05/23 06:59:18, hajimehoshi wrote:
> Thanks!
> 
>
https://codereview.chromium.org/15728008/diff/1/chrome/renderer/translate/tra...
> File chrome/renderer/translate/translate_helper.cc (right):
> 
>
https://codereview.chromium.org/15728008/diff/1/chrome/renderer/translate/tra...
> chrome/renderer/translate/translate_helper.cc:116: // TODO(hajimehoshi): this
> parameter should be set only if
> On 2013/05/23 06:54:53, Takashi Toyoshima (chromium) wrote:
> > this -> This.
> > 
> > Probably, we can say,
> > "If this affects performance, it can be set if"...
> 
> Done.

[Evan Stade, 2013-05-23 16:48:58]

lgtm, but please improve the CL description - it doesn't mention what feature
it's affecting.

https://codereview.chromium.org/15728008/diff/2002/chrome/browser/resources/t...
File chrome/browser/resources/translate_internals/translate_internals.js
(right):

https://codereview.chromium.org/15728008/diff/2002/chrome/browser/resources/t...
chrome/browser/resources/translate_internals/translate_internals.js:10: var
detectionLogs_ = null;
docs

[hajimehoshi, 2013-05-24 02:20:48]

Thanks.  I modified the description.

On 2013/05/23 16:48:58, Evan Stade wrote:
> lgtm, but please improve the CL description - it doesn't mention what feature
> it's affecting.
> 
>
https://codereview.chromium.org/15728008/diff/2002/chrome/browser/resources/t...
> File chrome/browser/resources/translate_internals/translate_internals.js
> (right):
> 
>
https://codereview.chromium.org/15728008/diff/2002/chrome/browser/resources/t...
> chrome/browser/resources/translate_internals/translate_internals.js:10: var
> detectionLogs_ = null;
> docs

[hajimehoshi, 2013-05-24 03:55:52]

+sky, can you take a look at chrome/common/language_detection_details.h?  Thank
you in advance.

On 2013/05/24 02:20:48, hajimehoshi wrote:
> Thanks.  I modified the description.
> 
> On 2013/05/23 16:48:58, Evan Stade wrote:
> > lgtm, but please improve the CL description - it doesn't mention what
feature
> > it's affecting.
> > 
> >
>
https://codereview.chromium.org/15728008/diff/2002/chrome/browser/resources/t...
> > File chrome/browser/resources/translate_internals/translate_internals.js
> > (right):
> > 
> >
>
https://codereview.chromium.org/15728008/diff/2002/chrome/browser/resources/t...
> > chrome/browser/resources/translate_internals/translate_internals.js:10: var
> > detectionLogs_ = null;
> > docs

[sky, 2013-05-24 16:16:19]

LGTM

[hajimehoshi, 2013-05-27 00:47:38]

ping +cdn, can you take a look at chrome/common/render_messages.h?

[Cris Neckar, 2013-05-29 20:28:16]

On 2013/05/27 00:47:38, hajimehoshi wrote:
> ping +cdn, can you take a look at chrome/common/render_messages.h?

IPC changes LGTM

[commit-bot: I haz the power, 2013-05-30 03:17:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/15728008/26001

[commit-bot: I haz the power, 2013-05-30 06:02:34]

Change committed as 203093