Open new-window links externally from within packaged apps.

Open new-window links externally from within packaged apps. 

From within a packaged app, clicking target=_blank links or calling window.open will now launch the given URL using the system's default handler. 

This behavior only affects Linux, OS X, and Windows builds. 

BUG=145646, 227011
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203909

[Ken Rockot(use gerrit already), 2013-05-24 23:58:20]

ptal

Testing strategy is bad; not sure what a good one might look like in this case.

[miket_OOO, 2013-06-03 21:12:38]

lgtm

https://codereview.chromium.org/15720009/diff/1/chrome/browser/ui/extensions/...
File chrome/browser/ui/extensions/shell_window.cc (right):

https://codereview.chromium.org/15720009/diff/1/chrome/browser/ui/extensions/...
chrome/browser/ui/extensions/shell_window.cc:85: return NULL;
Hmmm. Is this a common pattern? Fine if it is; it just looks weird to do a ninja
delete and then pretend it never existed. Maybe this is how this interface
allows chaining of handlers.

[Ken Rockot(use gerrit already), 2013-06-03 21:24:47]

https://codereview.chromium.org/15720009/diff/1/chrome/browser/ui/extensions/...
File chrome/browser/ui/extensions/shell_window.cc (right):

https://codereview.chromium.org/15720009/diff/1/chrome/browser/ui/extensions/...
chrome/browser/ui/extensions/shell_window.cc:85: return NULL;
On 2013/06/03 21:12:38, miket wrote:
> Hmmm. Is this a common pattern? Fine if it is; it just looks weird to do a
ninja
> delete and then pretend it never existed. Maybe this is how this interface
> allows chaining of handlers.

It's not terribly common, but it's not unheard of. It looks like content
blocking essentially works the same way.

[commit-bot: I haz the power, 2013-06-03 21:47:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rockot@chromium.org/15720009/1

[commit-bot: I haz the power, 2013-06-04 08:38:59]

Change committed as 203909