Issue 15716006: Fixed reporting of PrintPreview.PageCount.PrintToCloudPrintWebDialog.

Issue 15716006: Fixed reporting of PrintPreview.PageCount.PrintToCloudPrintWebDialog. (Closed)

Created:
7 years, 7 months ago by Vitaly Buka (NO REVIEWS)

Modified:
7 years, 6 months ago

Reviewers:
gene, Toscano

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixed reporting of PrintPreview.PageCount.PrintToCloudPrintWebDialog. Removed unused code path and moved counting to proper location. Added counter native printing code, because native dialog on ChromeOS is actually Cloud Print Web Dialog. BUG=244059 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202746

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -29 lines)			Patch
M	chrome/browser/resources/print_preview/native_layer.js	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/print_preview/print_preview.js	View	1	1 chunk	+2 lines, -1 line	1 comment	Download
M	chrome/browser/ui/webui/print_preview/print_preview_handler.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview/print_preview_handler.cc	View		6 chunks	+18 lines, -19 lines	0 comments	Download
M	chrome/renderer/printing/print_web_view_helper.cc	View	1	1 chunk	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Toscano

https://codereview.chromium.org/15716006/diff/13001/chrome/browser/resources/print_preview/print_preview.js File chrome/browser/resources/print_preview/print_preview.js (right): https://codereview.chromium.org/15716006/diff/13001/chrome/browser/resources/print_preview/print_preview.js#newcode821 chrome/browser/resources/print_preview/print_preview.js:821: this.printTicketStore_.pageRange.getPageNumberSet().size); I think you want .length not .size.

7 years, 7 months ago (2013-05-27 13:34:38 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/15716006/13001

7 years, 6 months ago (2013-05-28 20:28:29 UTC) #7

Message was sent while issue was closed.

Change committed as 202746

Expand Messages | Collapse Messages