Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 15715018: Make the Remove Extension dialog modal for win app list. (Closed)

Created:
7 years, 7 months ago by koz (OOO until 15th September)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, sadrul, ben+watch_chromium.org, tfarina, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Make the Remove Extension dialog modal for win app list. BUG=234594 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203107

Patch Set 1 #

Patch Set 2 : fix compile #

Patch Set 3 : mac fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -17 lines) Patch
M chrome/browser/ui/app_list/app_list_service.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_disabled.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_mac.mm View 1 2 5 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_service_ash.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/app_list/app_list_controller_win.cc View 1 3 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc View 1 2 chunks +8 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
koz (OOO until 15th September)
benwells: general code review sky: owners review
7 years, 7 months ago (2013-05-27 06:53:49 UTC) #1
benwells
lgtm
7 years, 7 months ago (2013-05-27 07:09:03 UTC) #2
sky
LGTM
7 years, 6 months ago (2013-05-28 14:25:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/15715018/1
7 years, 6 months ago (2013-05-28 23:28:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/15715018/21002
7 years, 6 months ago (2013-05-29 00:15:06 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-05-29 01:25:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/15715018/35001
7 years, 6 months ago (2013-05-30 00:30:32 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-05-30 01:10:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/15715018/35001
7 years, 6 months ago (2013-05-30 01:39:19 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-05-30 07:57:15 UTC) #10
Message was sent while issue was closed.
Change committed as 203107

Powered by Google App Engine
This is Rietveld 408576698