Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 15715014: app_mode: Add a flag for kiosk app settings UI. (Closed)

Created:
7 years, 7 months ago by xiyuan
Modified:
7 years, 6 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

app_mode: Add a flag for kiosk app settings UI. Disable kiosk app settings UI by default and add a flag to turn it on. This is a CL for M28 before it is moved to extensions UI. BUG=243859 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202699

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
xiyuan
zel for the main review and dbeam for owner's blessing.
7 years, 7 months ago (2013-05-24 20:34:19 UTC) #1
zel
lgtm
7 years, 7 months ago (2013-05-24 20:46:45 UTC) #2
Dan Beam
lgtm
7 years, 7 months ago (2013-05-24 21:17:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/15715014/1
7 years, 7 months ago (2013-05-24 21:21:04 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=118294
7 years, 7 months ago (2013-05-25 00:00:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/15715014/1
7 years, 7 months ago (2013-05-25 00:38:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/15715014/24001
7 years, 6 months ago (2013-05-28 17:41:30 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 00:06:22 UTC) #8
Message was sent while issue was closed.
Change committed as 202699

Powered by Google App Engine
This is Rietveld 408576698