Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15715005: Remove passphrase dialog and last parts of elevation. (Closed)

Created:
7 years, 7 months ago by Adrian Kuegel
Modified:
7 years, 6 months ago
CC:
chromium-reviews, pam+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Remove passphrase dialog and last parts of elevation. BUG=241383 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203452

Patch Set 1 #

Patch Set 2 : Also remove elevated_for_extensions #

Patch Set 3 : Also remove managed_user_passphrase_unittest. #

Total comments: 2

Patch Set 4 : Remove another line. #

Patch Set 5 : Sync #

Patch Set 6 : Sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -673 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 2 3 4 5 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/managed_mode/managed_mode_navigation_observer.h View 1 2 3 4 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/managed_mode/managed_mode_navigation_observer.cc View 1 2 3 4 2 chunks +1 line, -20 lines 0 comments Download
D chrome/browser/managed_mode/managed_user_passphrase.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/managed_mode/managed_user_passphrase.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/managed_mode/managed_user_passphrase_unittest.cc View 1 2 1 chunk +0 lines, -68 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_service.h View 1 2 3 4 5 5 chunks +0 lines, -19 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_service.cc View 1 2 3 4 5 4 chunks +0 lines, -47 lines 0 comments Download
D chrome/browser/resources/managed_user_passphrase_dialog.css View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/resources/managed_user_passphrase_dialog.html View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/resources/managed_user_passphrase_dialog.js View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/ui/webui/managed_user_passphrase_dialog.h View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/ui/webui/managed_user_passphrase_dialog.cc View 1 chunk +0 lines, -183 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 4 5 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Adrian Kuegel
Pam, can you please review the files in chrome/browser/managed_mode/* ?
7 years, 7 months ago (2013-05-24 09:28:12 UTC) #1
Pam (message me for reviews)
https://codereview.chromium.org/15715005/diff/8001/chrome/browser/managed_mode/managed_mode_navigation_observer.cc File chrome/browser/managed_mode/managed_mode_navigation_observer.cc (right): https://codereview.chromium.org/15715005/diff/8001/chrome/browser/managed_mode/managed_mode_navigation_observer.cc#newcode166 chrome/browser/managed_mode/managed_mode_navigation_observer.cc:166: if (!managed_user_service_->ProfileIsManaged()) This line needs to be removed too.
7 years, 7 months ago (2013-05-24 11:01:24 UTC) #2
Adrian Kuegel
https://codereview.chromium.org/15715005/diff/8001/chrome/browser/managed_mode/managed_mode_navigation_observer.cc File chrome/browser/managed_mode/managed_mode_navigation_observer.cc (right): https://codereview.chromium.org/15715005/diff/8001/chrome/browser/managed_mode/managed_mode_navigation_observer.cc#newcode166 chrome/browser/managed_mode/managed_mode_navigation_observer.cc:166: if (!managed_user_service_->ProfileIsManaged()) Right, I missed that. Thanks for noticing.
7 years, 7 months ago (2013-05-24 11:07:22 UTC) #3
Pam (message me for reviews)
LGTM! - Pam
7 years, 7 months ago (2013-05-24 11:10:21 UTC) #4
Adrian Kuegel
James, can you please review the stuff in chrome/browser/resources and chrome/browser/ui/webui?
7 years, 7 months ago (2013-05-24 11:12:33 UTC) #5
Adrian Kuegel
On 2013/05/24 11:12:33, Adrian Kuegel wrote: > James, can you please review the stuff in ...
7 years, 6 months ago (2013-05-31 13:09:37 UTC) #6
James Hawkins
lgtm
7 years, 6 months ago (2013-05-31 16:45:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/15715005/25001
7 years, 6 months ago (2013-05-31 16:52:47 UTC) #8
commit-bot: I haz the power
7 years, 6 months ago (2013-05-31 19:24:00 UTC) #9
Message was sent while issue was closed. 
Change committed as 203452

Powered by Google App Engine
This is Rietveld 408576698