Issue 15715003: Make app launcher Chrome Store UMA consistent with NTP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15715003: Make app launcher Chrome Store UMA consistent with NTP. (Closed)

Created:
7 years, 7 months ago by koz (OOO until 15th September)

Modified:
7 years, 7 months ago

Reviewers:
benwells, koz (OOO until 15th September), Evan Stade

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Aaron Boodman, tfarina, chromium-apps-reviews_chromium.org, sky

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make app launcher Chrome Store UMA consistent with NTP. The NTP puts the launch of a regular app into a different bucket than the launch of the special webstore app. This change makes the launcher do something analogous with the webstore and the chrome app. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202005

Patch Set 1 #

Patch Set 2 : bs #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -6 lines)			Patch
M	chrome/browser/ui/app_list/extension_app_item.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/app_list/search/app_result.cc	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/app_launcher_handler.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/app_launcher_handler.cc	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_constants.h	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

koz (OOO until 15th September)

estade: chrome/browser/ui/webui benwells: everything else sky: sorry, added you by accident :-)

7 years, 7 months ago (2013-05-23 05:04:44 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/15715003/2001

7 years, 7 months ago (2013-05-24 00:15:26 UTC) #5

Message was sent while issue was closed.

Change committed as 202005

Expand Messages | Collapse Messages