Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/unsugar.dart

Issue 1571433002: dart2js cps: Compute intercepted classes in optimize_interceptors. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: JSArray and JSInt are special Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/codegen/unsugar.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart b/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart
index f1f5dd041c59f509c76b5a4842d55ce2aa5d099b..2596b91bbbb2ed91f420f4a1ac4bb92df7c684f0 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart
@@ -2,7 +2,7 @@ library dart2js.unsugar_cps;
import '../../cps_ir/cps_ir_nodes.dart';
-import '../../cps_ir/optimizers.dart' show ParentVisitor, Pass;
+import '../../cps_ir/optimizers.dart' show Pass;
import '../../constants/values.dart';
import '../../elements/elements.dart';
import '../../js_backend/codegen/glue.dart';
@@ -219,8 +219,7 @@ class UnsugarVisitor extends TrampolineRecursiveVisitor implements Pass {
// Change 'receiver.foo()' to 'this.foo(receiver)'.
newReceiver = thisParameter;
} else {
- newReceiver = new Interceptor(receiver, node.sourceInformation)
- ..interceptedClasses.addAll(_glue.getInterceptedClassesOn(selector));
+ newReceiver = new Interceptor(receiver, node.sourceInformation);
if (receiver.hint != null) {
newReceiver.hint = new InterceptorEntity(receiver.hint);
}
@@ -234,7 +233,6 @@ class UnsugarVisitor extends TrampolineRecursiveVisitor implements Pass {
processInvokeMethodDirectly(InvokeMethodDirectly node) {
if (!_glue.isInterceptedMethod(node.target)) return;
- Selector selector = node.selector;
Primitive receiver = node.receiver.definition;
Primitive newReceiver;
@@ -244,8 +242,7 @@ class UnsugarVisitor extends TrampolineRecursiveVisitor implements Pass {
// Change 'receiver.foo()' to 'this.foo(receiver)'.
newReceiver = thisParameter;
} else {
- newReceiver = new Interceptor(receiver, node.sourceInformation)
- ..interceptedClasses.addAll(_glue.getInterceptedClassesOn(selector));
+ newReceiver = new Interceptor(receiver, node.sourceInformation);
if (receiver.hint != null) {
newReceiver.hint = new InterceptorEntity(receiver.hint);
}
@@ -255,8 +252,4 @@ class UnsugarVisitor extends TrampolineRecursiveVisitor implements Pass {
node.receiver = new Reference<Primitive>(newReceiver)..parent = node;
node.callingConvention = CallingConvention.Intercepted;
}
-
- processInterceptor(Interceptor node) {
- _glue.registerSpecializedGetInterceptor(node.interceptedClasses);
- }
}

Powered by Google App Engine
This is Rietveld 408576698