Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Issue 15714004: Use const_iterator while iterating const std::set<>& (Closed)

Created:
7 years, 7 months ago by kouhei (in TOK)
Modified:
7 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use const_iterator while iterating const std::set<>& BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202491

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/tracing/tracing_ui.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
kouhei (in TOK)
nduca: Would you review this patch? Not in a hurry. I found this while force-enabling ...
7 years, 7 months ago (2013-05-27 01:50:05 UTC) #1
kouhei (in TOK)
+fix reviewers, cc nduca: Would you review this patch? Not in a hurry.
7 years, 7 months ago (2013-05-27 01:51:46 UTC) #2
nduca
lgtm
7 years, 7 months ago (2013-05-27 08:48:51 UTC) #3
kouhei (in TOK)
Thanks for review!
7 years, 7 months ago (2013-05-27 08:54:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/15714004/1
7 years, 7 months ago (2013-05-27 08:54:53 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=154193
7 years, 7 months ago (2013-05-27 12:46:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/15714004/1
7 years, 7 months ago (2013-05-28 00:17:42 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-28 03:15:54 UTC) #8
Message was sent while issue was closed.
Change committed as 202491

Powered by Google App Engine
This is Rietveld 408576698