Supresses app permissions changed dialogs in kiosk mode.

Supresses app permissions changed dialogs in kiosk mode.
Added tweak for running chromeos=1 builds on Linux machines.

BUG=242370
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202658

[zel, 2013-05-23 02:43:52]

https://codereview.chromium.org/15713003/diff/1/chrome/common/extensions/perm...
File chrome/common/extensions/permissions/chrome_api_permissions.cc (right):

https://codereview.chromium.org/15713003/diff/1/chrome/common/extensions/perm...
chrome/common/extensions/permissions/chrome_api_permissions.cc:254:
APIPermissionInfo::kFlagNone, 0, PermissionMessage::kNone,
ignore this part for now, that's going to be merged with
https://chromiumcodereview.appspot.com/13947050/

[xiyuan, 2013-05-23 03:05:38]

LGTM but let's wait for miket@.

https://codereview.chromium.org/15713003/diff/1/chrome/browser/extensions/ext...
File chrome/browser/extensions/extension_service.cc (right):

https://codereview.chromium.org/15713003/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_service.cc:2206: bool is_default_app_install
=
nit: Give |is_default_app_install| a new name since it is no longer just default
app, e.g. auto_grant_permission.

[miket_OOO, 2013-05-24 15:45:19]

lgtm

https://codereview.chromium.org/15713003/diff/1/chrome/browser/extensions/ext...
File chrome/browser/extensions/extension_service.cc (right):

https://codereview.chromium.org/15713003/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_service.cc:2206: bool is_default_app_install
=
On 2013/05/23 03:05:39, xiyuan wrote:
> nit: Give |is_default_app_install| a new name since it is no longer just
default
> app, e.g. auto_grant_permission.

Yes.

[zel, 2013-05-24 22:10:05]

https://codereview.chromium.org/15713003/diff/1/chrome/browser/extensions/ext...
File chrome/browser/extensions/extension_service.cc (right):

https://codereview.chromium.org/15713003/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_service.cc:2206: bool is_default_app_install
=
On 2013/05/24 15:45:19, miket wrote:
> On 2013/05/23 03:05:39, xiyuan wrote:
> > nit: Give |is_default_app_install| a new name since it is no longer just
> default
> > app, e.g. auto_grant_permission.
> 
> Yes.

Done.

[commit-bot: I haz the power, 2013-05-24 22:10:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/15713003/12001

[commit-bot: I haz the power, 2013-05-24 22:20:39]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[zel, 2013-05-24 22:30:03]

+bryeung for OWNER review of chrome/browser/usb/* part

[bryeung, 2013-05-27 12:40:54]

https://codereview.chromium.org/15713003/diff/12001/chrome/browser/usb/usb_se...
File chrome/browser/usb/usb_service.cc (right):

https://codereview.chromium.org/15713003/diff/12001/chrome/browser/usb/usb_se...
chrome/browser/usb/usb_service.cc:78: if (base::chromeos::IsRunningOnChromeOS())
{
This looks very wrong, so I must not understand.  When can this be false given
the #if above?  Does kiosk mode trigger defined(OS_CHROMEOS) but not
IsRunningOnChromeOS?

[zel, 2013-05-27 18:48:12]

https://codereview.chromium.org/15713003/diff/12001/chrome/browser/usb/usb_se...
File chrome/browser/usb/usb_service.cc (right):

https://codereview.chromium.org/15713003/diff/12001/chrome/browser/usb/usb_se...
chrome/browser/usb/usb_service.cc:78: if (base::chromeos::IsRunningOnChromeOS())
{
On 2013/05/27 12:40:54, bryeung wrote:
> This looks very wrong, so I must not understand.  When can this be false given
> the #if above?  Does kiosk mode trigger defined(OS_CHROMEOS) but not
> IsRunningOnChromeOS?

base::chromeos::IsRunningOnChromeOS() returns false when you run
GYP_DEFINES=chromeos=1 build on your LInux workstation.  It return true on the
actual CrOS hardware. So, this change is needed to support testing of
ChromeOS-flavored builds on system without PermissonBroker.

[bryeung, 2013-05-27 18:50:26]

lgtm

https://codereview.chromium.org/15713003/diff/12001/chrome/browser/usb/usb_se...
File chrome/browser/usb/usb_service.cc (right):

https://codereview.chromium.org/15713003/diff/12001/chrome/browser/usb/usb_se...
chrome/browser/usb/usb_service.cc:78: if (base::chromeos::IsRunningOnChromeOS())
{
On 2013/05/27 18:48:12, zel wrote:
> On 2013/05/27 12:40:54, bryeung wrote:
> > This looks very wrong, so I must not understand.  When can this be false
given
> > the #if above?  Does kiosk mode trigger defined(OS_CHROMEOS) but not
> > IsRunningOnChromeOS?
> 
> base::chromeos::IsRunningOnChromeOS() returns false when you run
> GYP_DEFINES=chromeos=1 build on your LInux workstation.  It return true on the
> actual CrOS hardware. So, this change is needed to support testing of
> ChromeOS-flavored builds on system without PermissonBroker.

Got it: thanks for the explanation.  A brief comment here might help prevent
confusion in the future.

[zel, 2013-05-28 16:58:26]

https://codereview.chromium.org/15713003/diff/12001/chrome/browser/usb/usb_se...
File chrome/browser/usb/usb_service.cc (right):

https://codereview.chromium.org/15713003/diff/12001/chrome/browser/usb/usb_se...
chrome/browser/usb/usb_service.cc:78: if (base::chromeos::IsRunningOnChromeOS())
{
On 2013/05/27 18:50:26, bryeung wrote:
> On 2013/05/27 18:48:12, zel wrote:
> > On 2013/05/27 12:40:54, bryeung wrote:
> > > This looks very wrong, so I must not understand.  When can this be false
> given
> > > the #if above?  Does kiosk mode trigger defined(OS_CHROMEOS) but not
> > > IsRunningOnChromeOS?
> > 
> > base::chromeos::IsRunningOnChromeOS() returns false when you run
> > GYP_DEFINES=chromeos=1 build on your LInux workstation.  It return true on
the
> > actual CrOS hardware. So, this change is needed to support testing of
> > ChromeOS-flavored builds on system without PermissonBroker.
> 
> Got it: thanks for the explanation.  A brief comment here might help prevent
> confusion in the future.

Done.

[commit-bot: I haz the power, 2013-05-28 16:58:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/15713003/25001

[commit-bot: I haz the power, 2013-05-28 21:48:20]

Change committed as 202658