Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 15712006: Regexp parser: reset flag after scanning ahead for capture groups. (Closed)

Created:
7 years, 7 months ago by Yang
Modified:
7 years, 7 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Regexp parser: reset flag after scanning ahead for capture groups. When the regexp pattern parser encounters an unbound reference to a capturing group, it needs to scan ahead to decide whether it really is a reference. The scan advances to the end of the pattern string and sets has_more_ to false, but fails to reset it to true so that later on, parsing a character class wrongly fails. R=ulan@chromium.org BUG=v8:2690 Committed: https://code.google.com/p/v8/source/detail?r=14817

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M src/parser.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-2690.js View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years, 7 months ago (2013-05-27 10:43:16 UTC) #1
ulan
lgtm
7 years, 7 months ago (2013-05-27 10:52:56 UTC) #2
Yang
7 years, 7 months ago (2013-05-27 10:53:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14817 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698