Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: chrome/browser/sync_file_system/drive_metadata_store.cc

Issue 15711009: [SyncFileSystem][Clean up] Delete DriveMetadataDB::DeleteEntry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync_file_system/drive_metadata_store.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync_file_system/drive_metadata_store.cc
diff --git a/chrome/browser/sync_file_system/drive_metadata_store.cc b/chrome/browser/sync_file_system/drive_metadata_store.cc
index 89eb3aa9060c3eee91dc02f564a7a9008a41cdc0..6aeca833b527656707772e53b2bfd74bd982b93d 100644
--- a/chrome/browser/sync_file_system/drive_metadata_store.cc
+++ b/chrome/browser/sync_file_system/drive_metadata_store.cc
@@ -115,7 +115,6 @@ class DriveMetadataDB {
const std::string& resource_id);
SyncStatusCode UpdateEntry(const FileSystemURL& url,
DriveMetadata metadata);
- SyncStatusCode DeleteEntry(const FileSystemURL& url);
// TODO(calvinlo): consolidate these state transition functions for sync
// origins like "UpdateOrigin(GURL, SyncStatusEnum)". And manage origins in
@@ -432,14 +431,9 @@ void DriveMetadataStore::DeleteEntry(
}
if (found->second.erase(url.path()) == 1) {
- base::PostTaskAndReplyWithResult(
- file_task_runner_.get(),
- FROM_HERE,
- base::Bind(
- &DriveMetadataDB::DeleteEntry, base::Unretained(db_.get()), url),
- base::Bind(&DriveMetadataStore::UpdateDBStatusAndInvokeCallback,
- AsWeakPtr(),
- callback));
+ scoped_ptr<leveldb::WriteBatch> batch(new leveldb::WriteBatch);
+ batch->Delete(FileSystemURLToMetadataKey(url));
+ WriteToDB(batch.Pass(), callback);
return;
}
@@ -634,6 +628,16 @@ void DriveMetadataStore::DidUpdateOrigin(
callback.Run(status);
}
+void DriveMetadataStore::WriteToDB(scoped_ptr<leveldb::WriteBatch> batch,
+ const SyncStatusCallback& callback) {
+ base::PostTaskAndReplyWithResult(
+ file_task_runner_, FROM_HERE,
+ base::Bind(&DriveMetadataDB::WriteToDB,
+ base::Unretained(db_.get()), base::Owned(batch.release())),
+ base::Bind(&DriveMetadataStore::UpdateDBStatusAndInvokeCallback,
+ AsWeakPtr(), callback));
+}
+
void DriveMetadataStore::UpdateDBStatus(SyncStatusCode status) {
DCHECK(CalledOnValidThread());
if (db_status_ != SYNC_STATUS_OK &&
@@ -937,16 +941,6 @@ SyncStatusCode DriveMetadataDB::UpdateEntry(const FileSystemURL& url,
return WriteToDB(&batch);
}
-SyncStatusCode DriveMetadataDB::DeleteEntry(const FileSystemURL& url) {
- DCHECK(CalledOnValidThread());
- DCHECK(db_.get());
-
- std::string metadata_key = FileSystemURLToMetadataKey(url);
- leveldb::WriteBatch batch;
- batch.Delete(metadata_key);
- return WriteToDB(&batch);
-}
-
SyncStatusCode DriveMetadataDB::UpdateOriginAsIncrementalSync(
const GURL& origin, const std::string& resource_id) {
DCHECK(CalledOnValidThread());
« no previous file with comments | « chrome/browser/sync_file_system/drive_metadata_store.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698