Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 15711007: Remove "--hsts-hosts" command-line argument (Closed)

Created:
7 years, 7 months ago by unsafe
Modified:
7 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, sail+watch_chromium.org
Base URL:
https://src.chromium.org/chrome/trunk/src/
Visibility:
Public.

Description

Remove "--hsts-hosts" so we don't have to maintain it during upcoming changes to the TransportSecurityState data structures and JSON format. The "--hsts-hosts" feature is likely unused, is redundant with net-internals, and is dangerous since it fails silently. Also it exposes the internal JSON format to the user. BUG=156152 R=rsleevi,palmer Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202957

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -78 lines) Patch
M chrome/browser/net/transport_security_persister.h View 2 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/net/transport_security_persister.cc View 2 chunks +2 lines, -14 lines 0 comments Download
M chrome/browser/net/transport_security_persister_unittest.cc View 1 2 3 1 chunk +0 lines, -22 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M net/http/transport_security_state.h View 2 chunks +0 lines, -12 lines 0 comments Download
M net/http/transport_security_state.cc View 1 2 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
unsafe
This is a small slice off the overly-large CL: https://codereview.chromium.org/12974003/
7 years, 7 months ago (2013-05-26 16:34:47 UTC) #1
agl
+cc: cevans, who added it in the first place I believe. But, in general, LGTM.
7 years, 6 months ago (2013-05-28 14:54:33 UTC) #2
Chris Evans
On 2013/05/28 14:54:33, agl wrote: > +cc: cevans, who added it in the first place ...
7 years, 6 months ago (2013-05-28 16:56:15 UTC) #3
palmer
LGTM. Thanks! cevans, you can still make such recipes by adding the pins in chrome://net-internals/#hsts, ...
7 years, 6 months ago (2013-05-28 18:25:24 UTC) #4
Ryan Sleevi
lgtm
7 years, 6 months ago (2013-05-28 18:26:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/unsafe@trevp.net/15711007/11001
7 years, 6 months ago (2013-05-28 18:27:03 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=5274
7 years, 6 months ago (2013-05-28 18:49:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/unsafe@trevp.net/15711007/11001
7 years, 6 months ago (2013-05-28 20:49:34 UTC) #8
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=5357
7 years, 6 months ago (2013-05-28 21:23:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/unsafe@trevp.net/15711007/11001
7 years, 6 months ago (2013-05-28 23:04:39 UTC) #10
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=5432
7 years, 6 months ago (2013-05-28 23:17:47 UTC) #11
unsafe
On 2013/05/28 23:17:47, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 6 months ago (2013-05-28 23:38:40 UTC) #12
agl
Have emailed Miranda because codereview doesn't seem to want to let me change the reviewers.
7 years, 6 months ago (2013-05-29 14:33:34 UTC) #13
Miranda Callahan
On 2013/05/29 14:33:34, agl wrote: > Have emailed Miranda because codereview doesn't seem to want ...
7 years, 6 months ago (2013-05-29 14:42:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/unsafe@trevp.net/15711007/11001
7 years, 6 months ago (2013-05-29 14:51:08 UTC) #15
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-05-29 15:19:58 UTC) #16
unsafe
On 2013/05/29 15:19:58, I haz the power (commit-bot) wrote: > Sorry for I got bad ...
7 years, 6 months ago (2013-05-29 17:24:27 UTC) #17
Ryan Sleevi
Diff from patch 3 LGTM. CQing.
7 years, 6 months ago (2013-05-29 17:28:35 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/unsafe@trevp.net/15711007/44001
7 years, 6 months ago (2013-05-29 17:29:21 UTC) #19
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 20:45:20 UTC) #20
Message was sent while issue was closed.
Change committed as 202957

Powered by Google App Engine
This is Rietveld 408576698