Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3152)

Unified Diff: base/message_pump.h

Issue 15709015: Make sure that the UI window created by base::MessagePumpForUI is destoyed on the same thread (Wind… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/message_loop/message_loop.cc ('k') | base/message_pump_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_pump.h
diff --git a/base/message_pump.h b/base/message_pump.h
index b2e0a425656c6962f7d960d3637e68eab48cab36..bd80707be29be25ed231ecc8942bc7ae0460047c 100644
--- a/base/message_pump.h
+++ b/base/message_pump.h
@@ -119,6 +119,15 @@ class BASE_EXPORT MessagePump : public RefCountedThreadSafe<MessagePump> {
// used on the thread that called Run.
virtual void ScheduleDelayedWork(const TimeTicks& delayed_work_time) = 0;
+ // Stops the pump and frees any resources that must to be freed on the thread
+ // that called Run(). The method should be called on the same thread that
+ // called Run().
+ //
+ // Note that this method is the last chance to run anything on the thread that
+ // called Run(). MessagePump is a ref-counted class. Its destructor can (and
+ // does) run on arbitraty thread.
darin (slow to review) 2013/06/18 20:31:16 nit: s/arbitraty/arbitrary/ This comment section
alexeypa (please no reviews) 2013/06/18 20:48:52 Done.
+ virtual void Shutdown() = 0;
+
protected:
virtual ~MessagePump();
friend class RefCountedThreadSafe<MessagePump>;
« no previous file with comments | « base/message_loop/message_loop.cc ('k') | base/message_pump_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698