Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15709011: Use a direct include of strings headers in url/, win8/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Use a direct include of strings headers in url/, win8/. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205663

Patch Set 1 #

Patch Set 2 : rebas3e #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -32 lines) Patch
M url/gurl.h View 1 chunk +1 line, -1 line 0 comments Download
M url/url_canon.h View 1 chunk +1 line, -1 line 0 comments Download
M url/url_canon_ip.h View 1 chunk +1 line, -1 line 0 comments Download
M url/url_parse.h View 1 chunk +1 line, -1 line 0 comments Download
M url/url_test_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M url/url_util.h View 1 chunk +1 line, -1 line 0 comments Download
M url/url_util_internal.h View 1 chunk +1 line, -1 line 0 comments Download
M win8/delegate_execute/chrome_util.h View 1 chunk +1 line, -1 line 0 comments Download
M win8/delegate_execute/chrome_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/delegate_execute/delegate_execute.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/delegate_execute/delegate_execute_operation.h View 1 chunk +1 line, -1 line 0 comments Download
M win8/delegate_execute/delegate_execute_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/delegate_execute/delegate_execute_util.h View 1 chunk +1 line, -1 line 0 comments Download
M win8/delegate_execute/delegate_execute_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/delegate_execute/delegate_execute_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/metro_driver/chrome_app_view_ash.h View 1 chunk +1 line, -1 line 0 comments Download
M win8/metro_driver/file_picker.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/metro_driver/file_picker_ash.h View 1 chunk +1 line, -1 line 0 comments Download
M win8/metro_driver/file_picker_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/metro_driver/secondary_tile.h View 1 chunk +1 line, -1 line 0 comments Download
M win8/metro_driver/toast_notification_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M win8/metro_driver/winrt_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M win8/test/metro_registration_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M win8/test/metro_registration_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/test/open_with_dialog_async.h View 1 chunk +1 line, -1 line 0 comments Download
M win8/test/open_with_dialog_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M win8/test/test_registrar.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/test/ui_automation_client.h View 1 chunk +1 line, -1 line 0 comments Download
M win8/test/ui_automation_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M win8/viewer/metro_viewer_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M win8/viewer/metro_viewer_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/15709011/1
7 years, 6 months ago (2013-06-10 23:16:46 UTC) #1
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-11 06:27:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/15709011/13002
7 years, 6 months ago (2013-06-11 15:08:51 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=161281
7 years, 6 months ago (2013-06-11 21:02:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/15709011/13002
7 years, 6 months ago (2013-06-11 21:03:39 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 22:52:00 UTC) #6
Message was sent while issue was closed. 
Change committed as 205663

Powered by Google App Engine
This is Rietveld 408576698