Make webkit_user_agent a standalone gyp

Make webkit_user_agent a standalone gyp

There's no reason for the webkit user_agent target to be included from
webkit_support.gyp, doing so just makes life really confusing and makes it
easier to accidentally introduce gyp cycles. This makes webkit_user_agent.gyp
a normal standalone gyp file.

BUG=245477
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203493

[grt (UTC plus 2), 2013-05-31 03:58:45]

chrome_frame/ lgtm

https://codereview.chromium.org/15709006/diff/1/webkit/common/user_agent/webk...
File webkit/common/user_agent/webkit_user_agent.gyp (right):

https://codereview.chromium.org/15709006/diff/1/webkit/common/user_agent/webk...
webkit/common/user_agent/webkit_user_agent.gyp:13: 'variables': [
[ -> {

[darin (slow to review), 2013-05-31 07:01:36]

OK, LGTM (modulo the typo)

[commit-bot: I haz the power, 2013-05-31 18:22:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/15709006/7001

[commit-bot: I haz the power, 2013-05-31 18:22:15]

Failed to apply patch for webkit/common/user_agent/webkit_user_agent.gyp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  A         webkit/common/user_agent/webkit_user_agent.gyp
  Copied webkit/common/user_agent/webkit_user_agent.gypi ->
webkit/common/user_agent/webkit_user_agent.gyp
  patching file webkit/common/user_agent/webkit_user_agent.gyp
  Hunk #2 FAILED at 64.
  1 out of 2 hunks FAILED -- saving rejects to file
webkit/common/user_agent/webkit_user_agent.gyp.rej

Patch:   NR 
webkit/common/user_agent/webkit_user_agent.gypi->webkit/common/user_agent/webkit_user_agent.gyp
Index: webkit/common/user_agent/webkit_user_agent.gyp
diff --git a/webkit/common/user_agent/webkit_user_agent.gypi
b/webkit/common/user_agent/webkit_user_agent.gyp
similarity index 95%
rename from webkit/common/user_agent/webkit_user_agent.gypi
rename to webkit/common/user_agent/webkit_user_agent.gyp
index
61e88ea131222f8b4ac6f09d93faa9a9115f9fa9..021df554d2c072c49b7ca62f829d9fe776470c2e
100644
--- a/webkit/common/user_agent/webkit_user_agent.gypi
+++ b/webkit/common/user_agent/webkit_user_agent.gyp
@@ -10,6 +10,9 @@
       'defines': [
         'WEBKIT_USER_AGENT_IMPLEMENTATION',
       ],
+      'variables': {
+        'chromium_code': 1,
+      },
       'dependencies': [
         '<(DEPTH)/base/base.gyp:base',
         '<(DEPTH)/base/base.gyp:base_i18n',
@@ -61,7 +64,7 @@
               'action': ['python', '<(script)',
'../../../third_party/WebKit/Source',
                          '<(SHARED_INTERMEDIATE_DIR)'],
               'variables': {
-                'script': '../build/webkit_version.py',
+                'script': '../../build/webkit_version.py',
               },
             },
           ],

[commit-bot: I haz the power, 2013-05-31 19:28:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/15709006/10001

[commit-bot: I haz the power, 2013-05-31 19:43:27]

Retried try job too often on ios_rel_device for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_de...

[commit-bot: I haz the power, 2013-05-31 19:45:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/15709006/25003

[commit-bot: I haz the power, 2013-05-31 19:58:41]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...

[commit-bot: I haz the power, 2013-05-31 20:10:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/15709006/25003

[commit-bot: I haz the power, 2013-05-31 22:31:48]

Change committed as 203493