Bot update!

scripts/master/factory/commands.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Set of utilities to add commands to a buildbot factory (BuildFactory).
 
 All the utility functions to add steps to a build factory here are not
 project-specific. See the other *_commands.py for project-specific commands.
 """
 
@@ skipping 917 matching lines @@
         command=cmd)
 
   def AddBotUpdateStep(self, env, gclient_specs, revision_mapping, server=None):
     """Add a step to force checkout to some state.
 
     This is meant to replace all gclient revert/sync steps.
     """
     cmd = ['python', self._bot_update_tool, '--specs', gclient_specs]
 
     PROPERTIES = {
         'root': '%(root:~src)s',

[iannucci, 2014/02/08 01:31:31]

I'm not sure if the default of 'src' is really good to have here, since it masks
the fact that root was empty, and may not always be appropriate.

[Ryan Tseng, 2014/02/08 01:52:21]

Done.

         'issue': '%(issue:-)s',
         'patchset': '%(patchset:-)s',
-        'master': '%(mastername:-)s'
+        'master': '%(mastername:-)s',
+        'revision': '%(revision:-)s',

[iannucci, 2014/02/08 01:31:31]

this should also pass through patch_url if it's defined

[Ryan Tseng, 2014/02/08 01:52:21]

Done.

     }
 
     for property_name, property_expr in PROPERTIES.iteritems():
       property_value = WithProperties(property_expr)
       if property_value:
         cmd.extend(['--%s' % property_name, property_value])
 
     if server:
       cmd.extend(['--server', server])
 
@@ skipping 343 matching lines @@
 
   def commandComplete(self, cmd):
     out = cmd.logs['stdio'].getText()
     build_properties = re.findall('BUILD_PROPERTY ([^=]*)=(.*)', out)
     for propname, value in build_properties:
       # findall can return strings containing CR characters, remove with strip.
       self.build.setProperty(propname, value.strip(), 'Step')
 
   def getText(self, cmd, results):
     return self.describe(True) + self.messages