Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15706007: [Mac] Fix crash when closing window if the devtools process was killed. (Closed)

Created:
7 years, 7 months ago by Alexei Svitkine (slow)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

[Mac] Fix crash when closing window if the devtools process was killed. Similar to http://crbug.com/237823. BUG=244259 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202700

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Alexei Svitkine (slow)
7 years, 7 months ago (2013-05-27 16:41:52 UTC) #1
Robert Sesek
LGTM
7 years, 6 months ago (2013-05-28 14:53:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/15706007/1
7 years, 6 months ago (2013-05-28 14:55:45 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=154531
7 years, 6 months ago (2013-05-28 18:41:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/15706007/1
7 years, 6 months ago (2013-05-28 18:56:44 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=154620
7 years, 6 months ago (2013-05-28 22:22:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/15706007/1
7 years, 6 months ago (2013-05-28 22:46:02 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 00:16:46 UTC) #8
Message was sent while issue was closed. 
Change committed as 202700

Powered by Google App Engine
This is Rietveld 408576698