Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 15706004: Shink HTMLToken by 1.5 kB (Closed)

Created:
7 years, 7 months ago by abarth-chromium
Modified:
7 years, 7 months ago
CC:
blink-reviews, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Shink HTMLToken by 1.5 kB HTMLToken has an inline vector for buffering characters during tokenization. We originally picked the inline capacity of this buffer somewhat arbitrarily. This CL tunes the number based on a somewhat non-scientific browse of a number of popular web sites. I instrumented content_shell to log the length of each complete DataVector. I then browsed around a variety of web sites to collect data. The 99% percentile of DataVector lengths was just shy of 250 characters. I rounded that up to 256 because powers of two are pretty. That means we'll malloc an external buffer less than 1% of the time, which seems fine. R=eseidel,tonyg NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151046

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M Source/core/html/parser/HTMLToken.h View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
abarth-chromium
7 years, 7 months ago (2013-05-23 22:15:57 UTC) #1
tonyg
lgtm
7 years, 7 months ago (2013-05-23 22:48:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/15706004/1
7 years, 7 months ago (2013-05-23 22:51:13 UTC) #3
eseidel
Fantastic! Thank you.
7 years, 7 months ago (2013-05-24 00:09:17 UTC) #4
eseidel
lgtm
7 years, 7 months ago (2013-05-24 00:09:23 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=7139
7 years, 7 months ago (2013-05-24 00:15:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/15706004/1
7 years, 7 months ago (2013-05-24 05:47:52 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-24 05:48:05 UTC) #8
Message was sent while issue was closed.
Change committed as 151046

Powered by Google App Engine
This is Rietveld 408576698