Issue 15704005: ui/shell_dialogs: Use base::string16 now that string16 was moved into base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15704005: ui/shell_dialogs: Use base::string16 now that string16 was moved into base namespace. (Closed)

Created:
7 years, 6 months ago by tfarina

Modified:
7 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ui/shell_dialogs: Use base::string16 now that string16 was moved into base namespace. base/string16.h was moved into base namespace in r191198 by Brett. BUG=None TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203908

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -45 lines)			Patch
M	ui/shell_dialogs/gtk/select_file_dialog_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/shell_dialogs/gtk/select_file_dialog_impl_gtk.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/shell_dialogs/gtk/select_file_dialog_impl_kde.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/shell_dialogs/select_file_dialog.h	View	10 chunks	+10 lines, -12 lines	0 comments	Download
M	ui/shell_dialogs/select_file_dialog.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/shell_dialogs/select_file_dialog_android.h	View	3 chunks	+8 lines, -9 lines	0 comments	Download
M	ui/shell_dialogs/select_file_dialog_android.cc	View	4 chunks	+7 lines, -8 lines	0 comments	Download
M	ui/shell_dialogs/select_file_dialog_mac.mm	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/shell_dialogs/select_file_dialog_win.cc	View	5 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/15704005/1

7 years, 6 months ago (2013-06-04 01:04:45 UTC) #2

Ben Goodger (Google)

7 years, 6 months ago (2013-06-04 19:43:00 UTC) #4

lgtm


On Tue, Jun 4, 2013 at 1:38 AM, <commit-bot@chromium.org> wrote:

> Change committed as 203908
>
>
https://chromiumcodereview.**appspot.com/15704005/<https://chromiumcodereview...
>

Expand Messages | Collapse Messages