Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15702003: Move webkit/user_agent/ into webkit/common (Closed)

Created:
7 years, 7 months ago by jamesr
Modified:
7 years, 7 months ago
CC:
chromium-reviews, vsevik, nkostylev+watch_chromium.org, tfarina, amit, jam, sail+watch_chromium.org, joi+watch-content_chromium.org, yurys, jochen+watch_chromium.org, robertshield, pfeldman, oshima+watch_chromium.org, grt+watch_chromium.org, darin-cc_chromium.org, stevenjb+watch_chromium.org, android-webview-reviews_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move webkit/user_agent/ into webkit/common webkit/user_agent/ defines a tidy little library that depends on almost nothing and can be used in any process. This moves it into webkit/common/user_agent/. It's still linked as a separate component in the shared_library build. BUG=237267 R=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201700

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -784 lines) Patch
M android_webview/common/aw_content_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/drive_integration_service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/help/help_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/version_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_content_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_content_client_ios.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/html_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/html_util_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/app/content_main_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/devtools_http_handler_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_url_request_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/common/shell_content_client.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/common/user_agent/user_agent.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webkit/common/user_agent/user_agent.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webkit/common/user_agent/user_agent_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/common/user_agent/user_agent_util.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webkit/common/user_agent/user_agent_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/common/user_agent/user_agent_util_ios.mm View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/common/user_agent/webkit_user_agent.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
A + webkit/common/user_agent/webkit_user_agent_export.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/glue/webkitplatformsupport_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/webkit_support.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/support/webkit_support.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_request_context.cc View 1 chunk +1 line, -1 line 0 comments Download
D webkit/user_agent/user_agent.h View 1 chunk +0 lines, -29 lines 0 comments Download
D webkit/user_agent/user_agent.cc View 1 chunk +0 lines, -133 lines 0 comments Download
D webkit/user_agent/user_agent_unittest.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D webkit/user_agent/user_agent_util.h View 1 chunk +0 lines, -38 lines 0 comments Download
D webkit/user_agent/user_agent_util.cc View 1 chunk +0 lines, -196 lines 0 comments Download
D webkit/user_agent/user_agent_util_ios.mm View 1 chunk +0 lines, -179 lines 0 comments Download
D webkit/user_agent/webkit_user_agent.gypi View 1 chunk +0 lines, -80 lines 0 comments Download
D webkit/user_agent/webkit_user_agent_export.h View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jamesr
every day i'm shuffling
7 years, 7 months ago (2013-05-22 08:28:53 UTC) #1
darin (slow to review)
LGTM
7 years, 7 months ago (2013-05-22 20:10:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/15702003/1
7 years, 7 months ago (2013-05-22 20:16:31 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=117274
7 years, 7 months ago (2013-05-22 22:21:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/15702003/7003
7 years, 7 months ago (2013-05-22 22:51:56 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-23 04:53:48 UTC) #6
Message was sent while issue was closed. 
Change committed as 201700

Powered by Google App Engine
This is Rietveld 408576698