|
BrowserContext should simply own DownloadManager
This patch changes BrowserContext so it store a DownloadManager
directly (as UserData), instead of storing a refptr to it.
Client code (mostly tests) that used refptrs was changed to use either
raw pointers or to use scoped_ptr/ScopedVector in case of
DownloadManagers created by it.
The Bind() in DownloadManagerImpl::CheckForFileRemoval() is now using
a weak pointer to itself.
BUG= 237871
TEST=content_unittests and {unit,browser}_tests with *Download* and *SavePage*
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202743
Total comments: 4
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+56 lines, -77 lines) |
Patch |
|
M |
chrome/browser/chromeos/drive/download_handler_unittest.cc
|
View
|
1
2
3
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/all_download_item_notifier_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/download/chrome_download_manager_delegate.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/download/chrome_download_manager_delegate_unittest.cc
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_browsertest.cc
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_history_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_shelf_unittest.cc
|
View
|
1
2
3
4
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_status_updater_unittest.cc
|
View
|
1
2
3
4
|
7 chunks |
+9 lines, -9 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_ui_controller_unittest.cc
|
View
|
1
2
3
4
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/browser/browser_context.cc
|
View
|
1
2
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
content/browser/download/download_id_unittest.cc
|
View
|
1
|
3 chunks |
+10 lines, -22 lines |
0 comments
|
Download
|
|
M |
content/browser/download/download_manager_impl.h
|
View
|
1
|
3 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
|
M |
content/browser/download/download_manager_impl.cc
|
View
|
1
2
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/browser/download/download_manager_impl_unittest.cc
|
View
|
|
4 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
content/public/browser/download_manager.h
|
View
|
|
2 chunks |
+3 lines, -8 lines |
0 comments
|
Download
|
|
M |
content/public/test/mock_download_manager.h
|
View
|
|
2 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
content/public/test/test_file_error_injector.h
|
View
|
1
|
3 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
|
M |
content/public/test/test_file_error_injector.cc
|
View
|
|
2 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
Total messages: 14 (0 generated)
|