Issue 15700014: Adding user into session doesn't generate login-prompt-visible.

Issue 15700014: Adding user into session doesn't generate login-prompt-visible. (Closed)

Created:
7 years, 6 months ago by dzhioev (left Google)

Modified:
7 years, 6 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Adding user into session doesn't generate login-prompt-visible. TEST=manually BUG=240739 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204029

Patch Set 2 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/chromeos/login/login_display_host_impl.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	chrome/browser/chromeos/login/webui_login_view.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

lgtm https://codereview.chromium.org/15700014/diff/1/chrome/browser/chromeos/login/login_display_host_impl.cc File chrome/browser/chromeos/login/login_display_host_impl.cc (right): https://codereview.chromium.org/15700014/diff/1/chrome/browser/chromeos/login/login_display_host_impl.cc#newcode412 chrome/browser/chromeos/login/login_display_host_impl.cc:412: login_view_->set_should_emit_login_prompt_visible(false); nit: Please add comment why we disable ...

7 years, 6 months ago (2013-06-03 13:03:58 UTC) #2

dzhioev (left Google)

https://codereview.chromium.org/15700014/diff/1/chrome/browser/chromeos/login/login_display_host_impl.cc File chrome/browser/chromeos/login/login_display_host_impl.cc (right): https://codereview.chromium.org/15700014/diff/1/chrome/browser/chromeos/login/login_display_host_impl.cc#newcode412 chrome/browser/chromeos/login/login_display_host_impl.cc:412: login_view_->set_should_emit_login_prompt_visible(false); On 2013/06/03 13:03:58, Nikita Kostylev wrote: > nit: ...

7 years, 6 months ago (2013-06-03 13:30:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/15700014/4001

7 years, 6 months ago (2013-06-03 13:30:41 UTC) #4

commit-bot: I haz the power

The commit queue went berserk retrying too often for a seemingly flaky test on builder ...

7 years, 6 months ago (2013-06-03 23:12:35 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/15700014/4001

7 years, 6 months ago (2013-06-04 14:35:05 UTC) #6

Message was sent while issue was closed.

Change committed as 204029

Expand Messages | Collapse Messages