Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Side by Side Diff: ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h

Issue 15697019: Parametrize names of llc and ld nexes by reading them from the resource info JSON file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Tweak comments some more, following Jan's review Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PNACL_COORDINATOR_H_ 5 #ifndef NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PNACL_COORDINATOR_H_
6 #define NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PNACL_COORDINATOR_H_ 6 #define NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PNACL_COORDINATOR_H_
7 7
8 #include <set> 8 #include <set>
9 #include <map> 9 #include <map>
10 #include <vector> 10 #include <vector>
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 private: 151 private:
152 NACL_DISALLOW_COPY_AND_ASSIGN(PnaclCoordinator); 152 NACL_DISALLOW_COPY_AND_ASSIGN(PnaclCoordinator);
153 153
154 // BitcodeToNative is the factory method for PnaclCoordinators. 154 // BitcodeToNative is the factory method for PnaclCoordinators.
155 // Therefore the constructor is private. 155 // Therefore the constructor is private.
156 PnaclCoordinator(Plugin* plugin, 156 PnaclCoordinator(Plugin* plugin,
157 const nacl::string& pexe_url, 157 const nacl::string& pexe_url,
158 const PnaclOptions& pnacl_options, 158 const PnaclOptions& pnacl_options,
159 const pp::CompletionCallback& translate_notify_callback); 159 const pp::CompletionCallback& translate_notify_callback);
160 160
161 // Callback for when the resource info JSON file has been read.
162 void ResourceInfoWasRead(int32_t pp_error);
163
161 // Callback for when llc and ld have been downloaded. 164 // Callback for when llc and ld have been downloaded.
162 // This is the first callback invoked in response to BitcodeToNative.
163 void ResourcesDidLoad(int32_t pp_error); 165 void ResourcesDidLoad(int32_t pp_error);
164 166
165 // Callbacks for temporary file related stages. 167 // Callbacks for temporary file related stages.
166 // They are invoked from ResourcesDidLoad and proceed in declaration order. 168 // They are invoked from ResourcesDidLoad and proceed in declaration order.
167 // Invoked when the temporary file system is successfully opened in PPAPI. 169 // Invoked when the temporary file system is successfully opened in PPAPI.
168 void FileSystemDidOpen(int32_t pp_error); 170 void FileSystemDidOpen(int32_t pp_error);
169 // Invoked after we are sure the PNaCl temporary directory exists. 171 // Invoked after we are sure the PNaCl temporary directory exists.
170 void DirectoryWasCreated(int32_t pp_error); 172 void DirectoryWasCreated(int32_t pp_error);
171 // Invoked after we have checked the PNaCl cache for a translated version. 173 // Invoked after we have checked the PNaCl cache for a translated version.
172 void CachedFileDidOpen(int32_t pp_error); 174 void CachedFileDidOpen(int32_t pp_error);
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
266 // The helper thread used to do translations via SRPC. 268 // The helper thread used to do translations via SRPC.
267 // Keep this last in declaration order to ensure the other variables 269 // Keep this last in declaration order to ensure the other variables
268 // haven't been destroyed yet when its destructor runs. 270 // haven't been destroyed yet when its destructor runs.
269 nacl::scoped_ptr<PnaclTranslateThread> translate_thread_; 271 nacl::scoped_ptr<PnaclTranslateThread> translate_thread_;
270 }; 272 };
271 273
272 //---------------------------------------------------------------------- 274 //----------------------------------------------------------------------
273 275
274 } // namespace plugin; 276 } // namespace plugin;
275 #endif // NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PNACL_COORDINATOR_H_ 277 #endif // NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PNACL_COORDINATOR_H_
OLDNEW
« no previous file with comments | « ppapi/native_client/src/trusted/plugin/plugin.gypi ('k') | ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698