Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 15697006: Fix Windows shared library build. (Closed)

Created:
7 years, 7 months ago by ulan
Modified:
7 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix Windows shared library build. We cannot dll-export templates. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14751

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M include/v8.h View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL
7 years, 7 months ago (2013-05-22 15:09:43 UTC) #1
Jakob Kummerow
lgtm
7 years, 7 months ago (2013-05-22 15:11:05 UTC) #2
ulan
7 years, 7 months ago (2013-05-22 15:12:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14751 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698