Issue 15695003: [Quota][Clean up] Drop StorageType in GlobalUsageCallback

Issue 15695003: [Quota][Clean up] Drop StorageType in GlobalUsageCallback (Closed)

Created:
7 years, 7 months ago by tzik

Modified:
7 years, 7 months ago

Reviewers:
kinuko, Dan Beam, tzik

CC:
chromium-reviews, darin-cc_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Quota][Clean up] Drop StorageType in GlobalUsageCallback This CL drops non-informative StorageType parameter from GlobalUsageCall. The value should be known by the original caller that makes the callback. TEST=should not break existing test TBR=arv@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202013

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : drop unrelated change #

Total comments: 4

Patch Set 4 : s/type/kStorageType*/ #

Patch Set 5 : rebase #

Patch Set 6 : testfix #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -63 lines)			Patch
M	chrome/browser/ui/webui/quota_internals/quota_internals_proxy.cc	View		1 chunk	+6 lines, -3 lines	0 comments	Download
M	webkit/quota/quota_manager.h	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	webkit/quota/quota_manager.cc	View	1 2 3	4 chunks	+9 lines, -9 lines	0 comments	Download
M	webkit/quota/quota_manager_unittest.cc	View		10 chunks	+6 lines, -25 lines	0 comments	Download
M	webkit/quota/quota_types.h	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	webkit/quota/usage_tracker.h	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	webkit/quota/usage_tracker.cc	View		6 chunks	+6 lines, -11 lines	0 comments	Download
M	webkit/quota/usage_tracker_unittest.cc	View	1 2 3 4 5	2 chunks	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

tzik

PTAL. StorageType in GlobalUsageCallback no longer makes sense. Let me drop it.

7 years, 7 months ago (2013-05-22 08:02:36 UTC) #1

kinuko

https://codereview.chromium.org/15695003/diff/3001/webkit/quota/quota_manager.cc File webkit/quota/quota_manager.cc (right): https://codereview.chromium.org/15695003/diff/3001/webkit/quota/quota_manager.cc#newcode1357 webkit/quota/quota_manager.cc:1357: GetCachedOrigins(type, &origins); You could simply specify kStorageTypeTemporary here? https://codereview.chromium.org/15695003/diff/3001/webkit/quota/quota_manager.cc#newcode1380 ...

7 years, 7 months ago (2013-05-22 10:51:33 UTC) #3

tzik

Thanks! https://codereview.chromium.org/15695003/diff/3001/webkit/quota/quota_manager.cc File webkit/quota/quota_manager.cc (right): https://codereview.chromium.org/15695003/diff/3001/webkit/quota/quota_manager.cc#newcode1357 webkit/quota/quota_manager.cc:1357: GetCachedOrigins(type, &origins); On 2013/05/22 10:51:33, kinuko wrote: > ...

7 years, 7 months ago (2013-05-22 11:33:47 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/15695003/18001

7 years, 7 months ago (2013-05-22 13:47:12 UTC) #5

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=4248

7 years, 7 months ago (2013-05-22 13:56:45 UTC) #6

tzik

+arv as a chrome/browser/ui/webui OWNERS. Could you take a look?

7 years, 7 months ago (2013-05-22 14:20:23 UTC) #7

tzik

Adding dbeam as a chrome/browser/ui/webui/OWNERS. Dan: Could you take a look to chrome/browser/ui/webui/quota_internals_proxy.cc change?

7 years, 7 months ago (2013-05-24 03:51:48 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/15695003/18001

7 years, 7 months ago (2013-05-24 04:13:09 UTC) #11

Message was sent while issue was closed.

Change committed as 202013

Expand Messages | Collapse Messages