Remove screen capturers from media/video/capture/screen.

Remove screen capturers from media/video/capture/screen.

Screen capturers have been moved to webrtc. This change 
switches chromoting and getUserMedia() to the new copy of the 
capturers in webrtc and removes old copy from media.

TBR=jschuh@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204966

[scherkus (not reviewing), 2013-06-05 23:53:15]

heads up this is going to conflict with dalecurtis'
https://codereview.chromium.org/16252006/

[DaleCurtis, 2013-06-05 23:59:20]

lol, unticked mine which modified this code since it's being deleted.

[DaleCurtis, 2013-06-06 00:22:42]

https://codereview.chromium.org/15692018/diff/47001/media/media.gyp
File media/media.gyp (left):

https://codereview.chromium.org/15692018/diff/47001/media/media.gyp#oldcode868
media/media.gyp:868: ['screen_capture_supported==1', {
TODO() remove this? There's a big chunk at the top setting it.

https://codereview.chromium.org/15692018/diff/47001/media/media.gyp#oldcode874
media/media.gyp:874: ['exclude', '^video/capture/screen/'],
Don't think you can remove this yet, since you'll end up including files on
iOS/Android that weren't there before.

https://codereview.chromium.org/15692018/diff/47001/media/media.gyp#oldcode1186
media/media.gyp:1186: ['exclude', '^video/capture/screen/'],
Ditto.

[alexeypa (please no reviews), 2013-06-06 20:16:19]

lgtm

https://chromiumcodereview.appspot.com/15692018/diff/47001/media/media.gyp
File media/media.gyp (left):

https://chromiumcodereview.appspot.com/15692018/diff/47001/media/media.gyp#ol...
media/media.gyp:1020: 'video/capture/screen/screen_capturer_unittest.cc',
nit: Do we run
|../third_party/webrtc/modules/modules.gyp:desktop_capture_unittests| routinely
on the main (or some other) waterfall?

https://chromiumcodereview.appspot.com/15692018/diff/47001/media/video/captur...
File media/video/capture/screen/screen_capturer_fake.h (left):

https://chromiumcodereview.appspot.com/15692018/diff/47001/media/video/captur...
media/video/capture/screen/screen_capturer_fake.h:19: class MEDIA_EXPORT
ScreenCapturerFake : public ScreenCapturer {
nit: It looks like ScreenCapturerFake is only used in src/remoting. Consider
moving it to src/remoting instead of webrtc. Unless, of course, we plan to use
it in webrtc unittests.

[Sergey Ulanov, 2013-06-06 21:13:57]

https://codereview.chromium.org/15692018/diff/47001/media/media.gyp
File media/media.gyp (left):

https://codereview.chromium.org/15692018/diff/47001/media/media.gyp#oldcode868
media/media.gyp:868: ['screen_capture_supported==1', {
On 2013/06/06 00:22:42, DaleCurtis wrote:
> TODO() remove this? There's a big chunk at the top setting it.

Done.

https://codereview.chromium.org/15692018/diff/47001/media/media.gyp#oldcode874
media/media.gyp:874: ['exclude', '^video/capture/screen/'],
On 2013/06/06 00:22:42, DaleCurtis wrote:
> Don't think you can remove this yet, since you'll end up including files on
> iOS/Android that weren't there before.

Done.

https://codereview.chromium.org/15692018/diff/47001/media/media.gyp#oldcode1020
media/media.gyp:1020: 'video/capture/screen/screen_capturer_unittest.cc',
On 2013/06/06 20:16:20, alexeypa wrote:
> nit: Do we run
> |../third_party/webrtc/modules/modules.gyp:desktop_capture_unittests|
routinely
> on the main (or some other) waterfall?

Yes, I enabled them on the webrtc buildbots:
http://build.chromium.org/p/client.webrtc/console

https://codereview.chromium.org/15692018/diff/47001/media/media.gyp#oldcode1186
media/media.gyp:1186: ['exclude', '^video/capture/screen/'],
On 2013/06/06 00:22:42, DaleCurtis wrote:
> Ditto.

This target no longer depends on desktop_capture module.

https://codereview.chromium.org/15692018/diff/47001/media/video/capture/scree...
File media/video/capture/screen/screen_capturer_fake.h (left):

https://codereview.chromium.org/15692018/diff/47001/media/video/capture/scree...
media/video/capture/screen/screen_capturer_fake.h:19: class MEDIA_EXPORT
ScreenCapturerFake : public ScreenCapturer {
On 2013/06/06 20:16:20, alexeypa wrote:
> nit: It looks like ScreenCapturerFake is only used in src/remoting. Consider
> moving it to src/remoting instead of webrtc. Unless, of course, we plan to use
> it in webrtc unittests.

Good point. Moved this file to remoting. Will remove it from webrtc.

[DaleCurtis, 2013-06-06 21:19:08]

media/ lgtm

[Sergey Ulanov, 2013-06-06 21:31:12]

+creis - please approve change in content_browser.gypi

[Charlie Reis, 2013-06-07 00:42:04]

content_browser.gypi LGTM with nit.

https://codereview.chromium.org/15692018/diff/68001/content/content_browser.gypi
File content/content_browser.gypi (right):

https://codereview.chromium.org/15692018/diff/68001/content/content_browser.g...
content/content_browser.gypi:17:
'../third_party/webrtc/modules/modules.gyp:desktop_capture',
nit: Alphabetize

[Sergey Ulanov, 2013-06-07 00:48:28]

https://codereview.chromium.org/15692018/diff/68001/content/content_browser.gypi
File content/content_browser.gypi (right):

https://codereview.chromium.org/15692018/diff/68001/content/content_browser.g...
content/content_browser.gypi:17:
'../third_party/webrtc/modules/modules.gyp:desktop_capture',
On 2013/06/07 00:42:05, creis wrote:
> nit: Alphabetize

Done.

[commit-bot: I haz the power, 2013-06-07 00:50:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/15692018/75001

[commit-bot: I haz the power, 2013-06-07 02:30:28]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Sergey Ulanov, 2013-06-07 06:53:35]

+jschuh in TBR for noop changes in chromoting_messages.h

[commit-bot: I haz the power, 2013-06-07 06:54:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/15692018/75001

[commit-bot: I haz the power, 2013-06-07 07:15:20]

Retried try job too often on ios_dbg_simulator for step(s) base_unittests,
compile, content_unittests, crypto_unittests, media_unittests, net_unittests,
sql_unittests, ui_unittests, url_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-06-07 17:21:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/15692018/97001

[commit-bot: I haz the power, 2013-06-07 22:39:51]

Change committed as 204966