Issue 15692004: Update representation-from-uses to support smi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15692004: Update representation-from-uses to support smi. (Closed)

Created:
7 years, 7 months ago by Toon Verwaest

Modified:
7 years, 7 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -5 lines)			Patch
M	src/hydrogen-instructions.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	1	5 chunks	+12 lines, -5 lines	0 comments	Download
M	src/string-stream.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/string-stream.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Jakob Kummerow

LGTM if you're sure that this doesn't make any instructions assume Smi representation that aren't ...

7 years, 7 months ago (2013-05-24 12:05:13 UTC) #2

Toon Verwaest

7 years, 7 months ago (2013-05-24 12:29:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r14801 (presubmit successful).