src/disassembler.cc - Issue 15691017: Make assertion scopes thread safe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/disassembler.cc

Issue 15691017: Make assertion scopes thread safe. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/disassembler.cc

diff --git a/src/disassembler.cc b/src/disassembler.cc

index e41734babdbe008d5eead38d53a7f5390fd6be43..5ec1dcb77cc917874d1d51e7fe6510a63966de92 100644

--- a/src/disassembler.cc

+++ b/src/disassembler.cc

@@ -115,8 +115,8 @@ static int DecodeIt(Isolate* isolate,

const V8NameConverter& converter,

byte* begin,

byte* end) {

- NoHandleAllocation ha(isolate);

- AssertNoAllocation no_alloc;

+ SealHandleScope shs(isolate);

+ DisallowHeapAllocation no_alloc;

ExternalReferenceEncoder ref_encoder;

Heap* heap = HEAP;

« src/api.cc ('K') | « src/deoptimizer.cc ('k') | src/elements.cc » ('j') | no next file with comments »