Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: include/v8.h

Issue 15691017: Make assertion scopes thread safe. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/accessors.cc » ('j') | src/api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index e19f5861366bf3ec06e15b666e07f77740f990de..94a3fc0f3c9073c0fe6ebb479783e9bb8e7b8bd5 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -4158,13 +4158,13 @@ class V8EXPORT PersistentHandleVisitor { // NOLINT
*/
class V8EXPORT AssertNoGCScope {
#ifndef DEBUG
- V8_INLINE(AssertNoGCScope(Isolate* isolate)) {}
+ // TODO(yangguo): remove isolate argument.
+ V8_INLINE(AssertNoGCScope(Isolate* isolate)) { }
#else
AssertNoGCScope(Isolate* isolate);
~AssertNoGCScope();
private:
- Isolate* isolate_;
- bool last_state_;
+ void* disallow_heap_allocation_;
#endif
};
« no previous file with comments | « no previous file | src/accessors.cc » ('j') | src/api.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698