Issue 15690021: drive: Move temporary file removal responsiblity to FileCache

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15690021: drive: Move temporary file removal responsiblity to FileCache (Closed)

Created:
7 years, 6 months ago by hashimoto

Modified:
7 years, 6 months ago

Reviewers:
kinaba

CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Move temporary file removal responsiblity to FileCache FileCache is responsible for all file operations, FileCacheMetadata should focus on metadata business. Remove FileCacheMetadata::RemoveTemporaryFiles() Rewrite FileCache::FreeDiskSpaceIfNeededFor with iterator. Add test for FileCache::FreeDiskSpaceIfNeededFor(). Make FileCache::Pin() public. BUG=234487 TEST=unit_tests R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204455

Patch Set 1 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+156 lines, -131 lines)			Patch
M	chrome/browser/chromeos/drive/file_cache.h	View	3 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_cache.cc	View	3 chunks	+52 lines, -46 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_cache_metadata.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_cache_metadata.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_cache_metadata_unittest.cc	View	1 chunk	+0 lines, -40 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_cache_unittest.cc	View	22 chunks	+97 lines, -23 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hashimoto

7 years, 6 months ago (2013-06-06 08:35:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r204455 (presubmit successful).

Expand Messages | Collapse Messages