Source/bindings/scripts/CodeGeneratorV8.pm - Issue 15690020: [binding] Check own property on named property accessor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/CodeGeneratorV8.pm

Issue 15690020: [binding] Check own property on named property accessor (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: udpated tests Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/collection-item-should-be-overridden-by-own-property-expected.txt ('k') | Source/bindings/tests/results/V8TestEventTarget.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/scripts/CodeGeneratorV8.pm

diff --git a/Source/bindings/scripts/CodeGeneratorV8.pm b/Source/bindings/scripts/CodeGeneratorV8.pm

index 554437e3648dd982b72b45d8e9705c7e88b4e0ea..6e12848e521f607d5a83cff071b4cd85357bfdc4 100644

--- a/Source/bindings/scripts/CodeGeneratorV8.pm

+++ b/Source/bindings/scripts/CodeGeneratorV8.pm

@@ -3472,6 +3472,8 @@ sub GenerateImplementationNamedPropertyGetter

$code .= " return v8Undefined();\n";

$code .= " if (info.Holder()->HasRealNamedCallbackProperty(name))\n";

$code .= " return v8Undefined();\n";

+ $code .= " if (info.Holder()->HasRealNamedProperty(name))\n";

+ $code .= " return v8Undefined();\n";

}

$code .= "\n";

$code .= " ASSERT(V8DOMWrapper::maybeDOMWrapper(info.Holder()));\n";

@@ -3545,6 +3547,8 @@ sub GenerateImplementationNamedPropertySetter

$code .= " return v8Undefined();\n";

$code .= " if (info.Holder()->HasRealNamedCallbackProperty(name))\n";

$code .= " return v8Undefined();\n";

+ $code .= " if (info.Holder()->HasRealNamedProperty(name))\n";

+ $code .= " return v8Undefined();\n";

}

$code .= " ${implClassName}* collection = toNative(info.Holder());\n";

$code .= GenerateNativeValueDefinition($namedSetterFunction, $namedSetterFunction->parameters->[0], "name", "propertyName", "info.GetIsolate()");