Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 15690016: Fix GTestMac.AssertNSEQ on Mac 64. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

Fix GTestMac.AssertNSEQ on Mac 64. Switch to NSStrings; NSNumbers may be tagged pointers. BUG=244703 TEST=Mac 64 tester goes green Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202944

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M testing/gtest_mac_unittest.mm View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
7 years, 6 months ago (2013-05-29 15:33:51 UTC) #1
Mark Mentovai
LGTM
7 years, 6 months ago (2013-05-29 15:38:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/15690016/1
7 years, 6 months ago (2013-05-29 16:13:27 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 19:50:03 UTC) #4
Message was sent while issue was closed.
Change committed as 202944

Powered by Google App Engine
This is Rietveld 408576698