Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 15690009: Fix AccessArgumentsAt on ARM. Use register for index. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2467 matching lines...) Expand 10 before | Expand all | Expand 10 after
2478 LInstruction* LChunkBuilder::DoAccessArgumentsAt(HAccessArgumentsAt* instr) { 2478 LInstruction* LChunkBuilder::DoAccessArgumentsAt(HAccessArgumentsAt* instr) {
2479 info()->MarkAsRequiresFrame(); 2479 info()->MarkAsRequiresFrame();
2480 LOperand* args = UseRegister(instr->arguments()); 2480 LOperand* args = UseRegister(instr->arguments());
2481 LOperand* length; 2481 LOperand* length;
2482 LOperand* index; 2482 LOperand* index;
2483 if (instr->length()->IsConstant() && instr->index()->IsConstant()) { 2483 if (instr->length()->IsConstant() && instr->index()->IsConstant()) {
2484 length = UseRegisterOrConstant(instr->length()); 2484 length = UseRegisterOrConstant(instr->length());
2485 index = UseOrConstant(instr->index()); 2485 index = UseOrConstant(instr->index());
2486 } else { 2486 } else {
2487 length = UseTempRegister(instr->length()); 2487 length = UseTempRegister(instr->length());
2488 index = Use(instr->index()); 2488 index = UseRegisterAtStart(instr->index());
2489 } 2489 }
2490 return DefineAsRegister(new(zone()) LAccessArgumentsAt(args, length, index)); 2490 return DefineAsRegister(new(zone()) LAccessArgumentsAt(args, length, index));
2491 } 2491 }
2492 2492
2493 2493
2494 LInstruction* LChunkBuilder::DoToFastProperties(HToFastProperties* instr) { 2494 LInstruction* LChunkBuilder::DoToFastProperties(HToFastProperties* instr) {
2495 LOperand* object = UseFixed(instr->value(), r0); 2495 LOperand* object = UseFixed(instr->value(), r0);
2496 LToFastProperties* result = new(zone()) LToFastProperties(object); 2496 LToFastProperties* result = new(zone()) LToFastProperties(object);
2497 return MarkAsCall(DefineFixed(result, r0), instr); 2497 return MarkAsCall(DefineFixed(result, r0), instr);
2498 } 2498 }
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
2626 2626
2627 2627
2628 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2628 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2629 LOperand* object = UseRegister(instr->object()); 2629 LOperand* object = UseRegister(instr->object());
2630 LOperand* index = UseRegister(instr->index()); 2630 LOperand* index = UseRegister(instr->index());
2631 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2631 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2632 } 2632 }
2633 2633
2634 2634
2635 } } // namespace v8::internal 2635 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698