Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 15690006: Prevent pop-up bubbles for managed networks from being clipped (Closed)

Created:
7 years, 6 months ago by bartfab (slow)
Modified:
7 years, 6 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Prevent pop-up bubbles for managed networks from being clipped In the network list on the settings page, the pop-up bubble for a managed network has that network's list entry as its parent. The list entry must allow overflow to be visible so that the bubble does not get clipped. BUG=243659 TEST=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202753

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/options/browser_options.css View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bartfab (slow)
Hi James, Could you please take a look?
7 years, 6 months ago (2013-05-28 10:40:11 UTC) #1
James Hawkins
lgtm
7 years, 6 months ago (2013-05-28 17:44:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/15690006/1
7 years, 6 months ago (2013-05-28 22:09:33 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 02:41:41 UTC) #4
Message was sent while issue was closed.
Change committed as 202753

Powered by Google App Engine
This is Rietveld 408576698