Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: content/browser/media/webrtc_browsertest.cc

Issue 15688006: Made sure empty-call-then-add-one-stream test doesn't do simultaneous negotiations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | content/test/data/media/peerconnection-call.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/utf_string_conversions.h" 6 #include "base/utf_string_conversions.h"
7 #include "content/browser/web_contents/web_contents_impl.h" 7 #include "content/browser/web_contents/web_contents_impl.h"
8 #include "content/public/common/content_switches.h" 8 #include "content/public/common/content_switches.h"
9 #include "content/public/test/browser_test_utils.h" 9 #include "content/public/test/browser_test_utils.h"
10 #include "content/shell/shell.h" 10 #include "content/shell/shell.h"
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 } 108 }
109 109
110 IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest, MANUAL_CanSetupCallAndSendDtmf) { 110 IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest, MANUAL_CanSetupCallAndSendDtmf) {
111 GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html")); 111 GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html"));
112 NavigateToURL(shell(), url); 112 NavigateToURL(shell(), url);
113 113
114 EXPECT_TRUE( 114 EXPECT_TRUE(
115 ExecuteJavascript("callAndSendDtmf('123,abc');")); 115 ExecuteJavascript("callAndSendDtmf('123,abc');"));
116 } 116 }
117 117
118 // TODO(miu): Test is flaky. http://crbug.com/236102
119 IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest, 118 IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest,
120 DISABLED_CanMakeEmptyCallThenAddStreamsAndRenegotiate) { 119 CanMakeEmptyCallThenAddStreamsAndRenegotiate) {
121 GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html")); 120 GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html"));
122 NavigateToURL(shell(), url); 121 NavigateToURL(shell(), url);
123 122
124 const char* kJavascript = 123 const char* kJavascript =
125 "makeEmptyCallThenAddOneStreamAndRenegotiate(" 124 "callEmptyThenAddOneStreamAndRenegotiate({video: true, audio: true});";
126 "{video: true, audio: true});";
127 EXPECT_TRUE(ExecuteJavascript(kJavascript)); 125 EXPECT_TRUE(ExecuteJavascript(kJavascript));
128 ExpectTitle("OK"); 126 ExpectTitle("OK");
129 } 127 }
130 128
131 // This test will make a complete PeerConnection-based call but remove the 129 // This test will make a complete PeerConnection-based call but remove the
132 // MSID and bundle attribute from the initial offer to verify that 130 // MSID and bundle attribute from the initial offer to verify that
133 // video is playing for the call even if the initiating client don't support 131 // video is playing for the call even if the initiating client don't support
134 // MSID. http://tools.ietf.org/html/draft-alvestrand-rtcweb-msid-02 132 // MSID. http://tools.ietf.org/html/draft-alvestrand-rtcweb-msid-02
135 #if defined(OS_WIN) && defined(USE_AURA) 133 #if defined(OS_WIN) && defined(USE_AURA)
136 // Disabled for win7_aura, see http://crbug.com/235089. 134 // Disabled for win7_aura, see http://crbug.com/235089.
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest, MANUAL_CallAndModifyStream) { 215 IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest, MANUAL_CallAndModifyStream) {
218 GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html")); 216 GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html"));
219 NavigateToURL(shell(), url); 217 NavigateToURL(shell(), url);
220 218
221 EXPECT_TRUE( 219 EXPECT_TRUE(
222 ExecuteJavascript("callWithNewVideoMediaStreamLaterSwitchToAudio();")); 220 ExecuteJavascript("callWithNewVideoMediaStreamLaterSwitchToAudio();"));
223 ExpectTitle("OK"); 221 ExpectTitle("OK");
224 } 222 }
225 223
226 } // namespace content 224 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/test/data/media/peerconnection-call.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698