Issue 15685017: Use CustomFrameViewAsh in ash::Shell::CreateDefaultNonClientFrameView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15685017: Use CustomFrameViewAsh in ash::Shell::CreateDefaultNonClientFrameView. (Closed)

Created:
7 years, 6 months ago by msw

Modified:
7 years, 6 months ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, sadrul, ben+watch_chromium.org, Mike Wittman, sky

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use CustomFrameViewAsh in ash::Shell::CreateDefaultNonClientFrameView. Misc Ash windows incorrectly get new style BubbleFrameViews. Revert new dialog style change to CreateDefaultNonClientFrameView. This reverts non-dialog Ash windows to the old CustomFrameViewAsh. See before/after pics at http://crbug.com/241810#c17 Dialogs get frames from DialogDelegate::CreateNonClientFrameView. ( where 'dialogs' are DialogDelegate[View] [subclass] instances ) BUG=241125, 241810, 166075 TEST=Only dialog windows have the new-style bubble border. No windows have a double-border issue. R=derat@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203092

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	ash/shell.cc	View		2 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/15685017/1

7 years, 6 months ago (2013-05-30 01:00:49 UTC) #3

Message was sent while issue was closed.

Change committed as 203092

Expand Messages | Collapse Messages