Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15685013: Test for user scripts getting greasemonkey APIs. (Closed)

Created:
7 years, 7 months ago by Yoyo Zhou
Modified:
7 years, 7 months ago
Reviewers:
Devlin, Yoyo Zhou
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Test for user scripts getting greasemonkey APIs. BUG=242890 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201855

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/extensions/convert_user_script_unittest.cc View 8 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Yoyo Zhou
This is a follow-up to https://codereview.chromium.org/15685011 and it's a regression test, in that it fails ...
7 years, 7 months ago (2013-05-23 01:55:40 UTC) #1
Devlin
lgtm
7 years, 7 months ago (2013-05-23 16:47:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/15685013/1
7 years, 7 months ago (2013-05-23 16:49:40 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-23 19:28:21 UTC) #4
Message was sent while issue was closed. 
Change committed as 201855

Powered by Google App Engine
This is Rietveld 408576698