Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: remoting/webapp/session_connector.js

Issue 15685008: Show a 'remember me' checkbox in the web-app when connecting to a host that supports pairing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reviewer comments. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/main.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/session_connector.js
diff --git a/remoting/webapp/session_connector.js b/remoting/webapp/session_connector.js
index dfe9280c922db54b60ad9bd0319b3f7c8e4dbd12..779a00fd948bba604facb5d8e7eea30a09f46f49 100644
--- a/remoting/webapp/session_connector.js
+++ b/remoting/webapp/session_connector.js
@@ -118,7 +118,8 @@ remoting.SessionConnector.prototype.reset = function() {
this.pendingXhr_ = null;
/**
- * @type {function(function(string):void): void}
+ * Function to interactively obtain the PIN from the user.
+ * @type {function(boolean, function(string):void):void}
* @private
*/
this.fetchPin_ = function(onPinFetched) {};
@@ -146,7 +147,7 @@ remoting.SessionConnector.prototype.reset = function() {
* Initiate a Me2Me connection.
*
* @param {remoting.Host} host The Me2Me host to which to connect.
- * @param {function(function(string):void):void} fetchPin Function to
+ * @param {function(boolean, function(string):void):void} fetchPin Function to
* interactively obtain the PIN from the user.
* @param {function(string, string, string,
* function(string, string): void): void}
@@ -313,7 +314,7 @@ remoting.SessionConnector.prototype.createSessionIfReady_ = function() {
return;
}
- var securityTypes = 'third_party,spake2_hmac,spake2_plain';
+ var securityTypes = 'third_party,spake2_pair,spake2_hmac,spake2_plain';
this.clientSession_ = new remoting.ClientSession(
this.hostJid_, this.clientJid_, this.hostPublicKey_, this.passPhrase_,
this.fetchPin_, this.fetchThirdPartyToken_, securityTypes, this.hostId_,
« no previous file with comments | « remoting/webapp/main.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698