Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Issue 15684004: Refine Views textfield state interaction, testing, and examples. (Closed)

Created:
7 years, 7 months ago by msw
Modified:
7 years, 7 months ago
Reviewers:
msw, oshima, sky
CC:
chromium-reviews, nona+watch_chromium.org, tfarina, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Refine Views textfield state interaction, testing, and examples. Ignore Views textfield CTRL+<key> shortcuts with Alt pressed. Matches Win and fixes ctrl+alt+[a/z/etc.] AltGr input for Polish, etc. (alternate grapheme input was triggering undo/select-all/etc.) Enforce and test read-only and obscured states more rigorously. (prevent cut/copy/paste as needed, this was not always checked before) Do not change the focusable state of textfields when changing read-only. (this matches windows native behavior better) Expand and refine a bunch of unit tests and the Views Example for textfields. BUG=238105, 131660 TEST=Read-only and obscured Textfields work as intended. Polish input (right-Alt)+a, (right-Alt)+z, etc. work as expected. Ctrl+Alt+a, Ctrl+Alt+z, etc. are no-op on views textfields. R=oshima@chromium.org TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201961

Patch Set 1 #

Patch Set 2 : Expand cut/copy/paste test. #

Total comments: 4

Patch Set 3 : Add and expand on comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -98 lines) Patch
M ui/views/controls/textfield/native_textfield_views.cc View 6 chunks +20 lines, -16 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views_unittest.cc View 1 2 8 chunks +131 lines, -80 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/textfield_example.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/examples/textfield_example.cc View 5 chunks +23 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
msw
Hey Oshima, please take a look; thanks!
7 years, 7 months ago (2013-05-23 10:46:09 UTC) #1
oshima
lgtm with nits https://codereview.chromium.org/15684004/diff/2001/ui/views/controls/textfield/native_textfield_views_unittest.cc File ui/views/controls/textfield/native_textfield_views_unittest.cc (right): https://codereview.chromium.org/15684004/diff/2001/ui/views/controls/textfield/native_textfield_views_unittest.cc#newcode148 ui/views/controls/textfield/native_textfield_views_unittest.cc:148: // ASSERT_NE(last_contents_, new_contents); Instead of leaving ...
7 years, 7 months ago (2013-05-23 17:52:57 UTC) #2
msw
Done, landing. https://codereview.chromium.org/15684004/diff/2001/ui/views/controls/textfield/native_textfield_views_unittest.cc File ui/views/controls/textfield/native_textfield_views_unittest.cc (right): https://codereview.chromium.org/15684004/diff/2001/ui/views/controls/textfield/native_textfield_views_unittest.cc#newcode148 ui/views/controls/textfield/native_textfield_views_unittest.cc:148: // ASSERT_NE(last_contents_, new_contents); On 2013/05/23 17:52:58, oshima ...
7 years, 7 months ago (2013-05-23 19:08:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/15684004/20001
7 years, 7 months ago (2013-05-23 19:08:38 UTC) #4
msw
TBR'ing sky for ui/views/examples/textfield_example.* OWNERS.
7 years, 7 months ago (2013-05-23 19:13:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/15684004/20001
7 years, 7 months ago (2013-05-23 19:13:22 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-24 01:43:10 UTC) #7
Message was sent while issue was closed.
Change committed as 201961

Powered by Google App Engine
This is Rietveld 408576698