Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 15682017: Move message_loop to the message_loop directory. (Closed)

Created:
7 years, 6 months ago by brettw
Modified:
7 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul
Visibility:
Public.

Description

Move message_loop to the message_loop directory. Keep a forwarding header to avoid updating all callers. BUG= TBR=avi Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206279

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3685 lines) Patch
M base/base.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M base/base.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M base/message_loop.h View 1 chunk +3 lines, -729 lines 0 comments Download
D base/message_loop.cc View 1 chunk +0 lines, -834 lines 0 comments Download
A + base/message_loop/message_loop.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + base/message_loop/message_loop.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + base/message_loop/message_loop_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D base/message_loop_unittest.cc View 1 chunk +0 lines, -2116 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
brettw
TBR=avi
7 years, 6 months ago (2013-06-11 20:47:34 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 6 months ago (2013-06-11 20:47:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/15682017/2001
7 years, 6 months ago (2013-06-11 20:49:06 UTC) #3
Avi (use Gerrit)
lgtm stamp
7 years, 6 months ago (2013-06-11 20:49:10 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-11 22:19:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/15682017/19001
7 years, 6 months ago (2013-06-14 00:05:14 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-14 03:27:50 UTC) #7
Message was sent while issue was closed.
Change committed as 206279

Powered by Google App Engine
This is Rietveld 408576698