Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1523)

Unified Diff: content/renderer/render_view_impl.cc

Issue 15682009: Eliminate SwapOut message parameters, keeping state in RVHM instead. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to get Android build fix Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/test/test_web_contents.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 284637ed3fa2e13ae134977571364a4347890fa1..0a83904f7a3f02bcb84b2b0a61bea0362f71d935 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -5624,7 +5624,7 @@ void RenderViewImpl::OnShouldClose() {
before_unload_end_time));
}
-void RenderViewImpl::OnSwapOut(const ViewMsg_SwapOut_Params& params) {
+void RenderViewImpl::OnSwapOut() {
// Only run unload if we're not swapped out yet, but send the ack either way.
if (!is_swapped_out_) {
// Swap this RenderView out so the tab can navigate to a page rendered by a
@@ -5657,8 +5657,7 @@ void RenderViewImpl::OnSwapOut(const ViewMsg_SwapOut_Params& params) {
webview()->setVisibilityState(WebKit::WebPageVisibilityStateHidden, false);
}
- // Just echo back the params in the ACK.
- Send(new ViewHostMsg_SwapOut_ACK(routing_id_, params));
+ Send(new ViewHostMsg_SwapOut_ACK(routing_id_));
}
void RenderViewImpl::NavigateToSwappedOutURL(WebKit::WebFrame* frame) {
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/test/test_web_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698