Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 15682007: Files.app: Removed a side effect of StepsRunner.next. (Closed)

Created:
7 years, 6 months ago by hirono
Modified:
7 years, 6 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, Aaron Boodman, rginda+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Files.app: Removed a side effect of StepsRunner.next. Originally getter StepsRunner.next has a side effect, thus if it is called twice in one step, it shows unexpected behaviors. This CL removed the side effect. BUG=246463 TEST=browser_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203933

Patch Set 1 #

Patch Set 2 : Fixed a JsDoc. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/test/data/extensions/api_test/file_manager_browsertest/background.js View 1 3 chunks +6 lines, -3 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
hirono
@mtomasz - Could you check this CL? Thank you very much!
7 years, 6 months ago (2013-06-04 02:35:47 UTC) #1
mtomasz
On 2013/06/04 02:35:47, hirono wrote: > @mtomasz - Could you check this CL? Thank you ...
7 years, 6 months ago (2013-06-04 03:41:55 UTC) #2
mtomasz
https://codereview.chromium.org/15682007/diff/3001/chrome/test/data/extensions/api_test/file_manager_browsertest/background.js File chrome/test/data/extensions/api_test/file_manager_browsertest/background.js (right): https://codereview.chromium.org/15682007/diff/3001/chrome/test/data/extensions/api_test/file_manager_browsertest/background.js#newcode38 chrome/test/data/extensions/api_test/file_manager_browsertest/background.js:38: * @type {Array.<function>} Oops! Thanks!
7 years, 6 months ago (2013-06-04 03:41:59 UTC) #3
hirono
On 2013/06/04 03:41:59, mtomasz wrote: > https://codereview.chromium.org/15682007/diff/3001/chrome/test/data/extensions/api_test/file_manager_browsertest/background.js > File chrome/test/data/extensions/api_test/file_manager_browsertest/background.js > (right): > > https://codereview.chromium.org/15682007/diff/3001/chrome/test/data/extensions/api_test/file_manager_browsertest/background.js#newcode38 ...
7 years, 6 months ago (2013-06-04 03:42:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/15682007/3001
7 years, 6 months ago (2013-06-04 03:43:10 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 12:35:06 UTC) #6
Message was sent while issue was closed.
Change committed as 203933

Powered by Google App Engine
This is Rietveld 408576698