Extract GetResolveFile into DownloadOperation.

Extract GetResolveFile into DownloadOperation.

This CL extracts the GetResolveFile into an operation class, with simplifying
the implementation by merging consecutive accesses to the metadata and cache
into a function.

BUG=242084
TEST=Ran unit_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202450

[hidehiko, 2013-05-24 06:29:06]

Thank you for your review in advance,
- hidehiko

[kinaba, 2013-05-24 09:10:23]

lgtm

https://codereview.chromium.org/15681009/diff/3002/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/file_system.cc (right):

https://codereview.chromium.org/15681009/diff/3002/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/file_system.cc:1159: void
FileSystem::CancelJobInScheduler(JobID id) {
You can remove this method.
This is used only for the cancellation from the drive protocol handler,
and at least for now it is unlikely used elsewhere.

[hashimoto, 2013-05-24 09:48:38]

lgtm

https://codereview.chromium.org/15681009/diff/3002/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/file_system/download_operation.cc (right):

https://codereview.chromium.org/15681009/diff/3002/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/file_system/download_operation.cc:109: FileError
AllocateCacheSpace(
nit: What this function does is more than just allocating disk space.
How about renaming this function to more generic name like
"PrepareForDownloadFile"?

[hidehiko, 2013-05-26 15:39:36]

Thank you for your review. PTAL?

https://codereview.chromium.org/15681009/diff/3002/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/file_system.cc (right):

https://codereview.chromium.org/15681009/diff/3002/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/file_system.cc:1159: void
FileSystem::CancelJobInScheduler(JobID id) {
On 2013/05/24 09:10:23, kinaba wrote:
> You can remove this method.
> This is used only for the cancellation from the drive protocol handler,
> and at least for now it is unlikely used elsewhere.

Done.

https://codereview.chromium.org/15681009/diff/3002/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/file_system/download_operation.cc (right):

https://codereview.chromium.org/15681009/diff/3002/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/file_system/download_operation.cc:109: FileError
AllocateCacheSpace(
On 2013/05/24 09:48:38, hashimoto wrote:
> nit: What this function does is more than just allocating disk space.
> How about renaming this function to more generic name like
> "PrepareForDownloadFile"?

Done.

[kinaba, 2013-05-27 01:11:02]

lgtm

[hashimoto, 2013-05-27 02:57:55]

lgtm

[commit-bot: I haz the power, 2013-05-27 03:04:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/15681009/15010

[commit-bot: I haz the power, 2013-05-27 04:11:50]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-05-27 09:25:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/15681009/24002

[commit-bot: I haz the power, 2013-05-27 09:56:21]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[kinaba, 2013-05-27 09:59:23]

@hidehiko
If it's fine with you, I can take over this patch and commit through rebase hell
for you tomorrow.

[commit-bot: I haz the power, 2013-05-27 12:55:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/15681009/24002

[hidehiko, 2013-05-27 12:58:15]

On 2013/05/27 12:55:49, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/hidehiko%40chromium.org/15681009/24002

@kinaba

Thank you for your offer.
According to the log, the compilation failure looks not related to this patch
itself. So, please let me re-send it to the CQ for now.
If it doesn't work until tomorrow, I'll ask you :-)

[commit-bot: I haz the power, 2013-05-27 17:52:23]

Change committed as 202450