Issue 15680006: Translate: make refresh mata tag check done in case insensitive

Issue 15680006: Translate: make refresh mata tag check done in case insensitive (Closed)

Created:
7 years, 7 months ago by Takashi Toyoshima

Modified:
7 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Translate: make refresh mata tag check done in case insensitive BUG=236781 TEST=browser_tests --gtest_filter='TranslateBrowserTest.*' Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202793

Patch Set 1 #

Total comments: 3

Patch Set 2 : EXPECT_EQ #

Patch Set 3 : (rebase) #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -18 lines)			Patch
M	chrome/browser/translate/translate_browsertest.cc	View	1	11 chunks	+47 lines, -14 lines	0 comments	Download
M	chrome/renderer/chrome_render_view_observer.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
A +	chrome/test/data/translate/refresh_meta_tag_casei.html	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/15680006/diff/1/chrome/browser/translate/translate_browsertest.cc File chrome/browser/translate/translate_browsertest.cc (right): https://codereview.chromium.org/15680006/diff/1/chrome/browser/translate/translate_browsertest.cc#newcode198 chrome/browser/translate/translate_browsertest.cc:198: EXPECT_TRUE(EqualsASCII(result, "PASS")); EXPECT_EQ("PASS", UTF16ToASCII(result)) typically gives more useful ...

7 years, 6 months ago (2013-05-28 14:28:49 UTC) #2

Takashi Toyoshima

Thanks. https://chromiumcodereview.appspot.com/15680006/diff/1/chrome/browser/translate/translate_browsertest.cc File chrome/browser/translate/translate_browsertest.cc (right): https://chromiumcodereview.appspot.com/15680006/diff/1/chrome/browser/translate/translate_browsertest.cc#newcode198 chrome/browser/translate/translate_browsertest.cc:198: EXPECT_TRUE(EqualsASCII(result, "PASS")); On 2013/05/28 14:28:49, sky wrote: > ...

7 years, 6 months ago (2013-05-28 23:58:03 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/15680006/6001

7 years, 6 months ago (2013-05-28 23:58:30 UTC) #4

Message was sent while issue was closed.

Change committed as 202793

Expand Messages | Collapse Messages