Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 15679004: Remove trailing commas from Chromium IDLs (Closed)

Created:
7 years, 7 months ago by Nils Barth (inactive)
Modified:
7 years, 7 months ago
CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield
Visibility:
Public.

Description

Remove trailing commas from Chromium IDLs This removes trailing commas in extended attributes from the 2 files that have them. This is not part of the standard, and doesn't work with strict parsers, but laxer parsers may not notice. This removes a barrier to using more standard-compliant parsers more widely; discovered when rewriting Blink IDL parser. BUG=242800 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201779

Patch Set 1 #

Patch Set 2 : rebased to HEAD #

Patch Set 3 : Oops, correct patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome_frame/chrome_tab.idl View 2 1 chunk +1 line, -1 line 0 comments Download
M google_update/google_update_idl.idl View 2 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Nils Barth (inactive)
Hiyas, A very minor fix -- trailing commas are not allowed in Web IDL grammar, ...
7 years, 7 months ago (2013-05-22 07:19:03 UTC) #1
slightlyoff
Have you verified that npchrome_frame.dll still links with this change? If so, LGTM. If not, ...
7 years, 7 months ago (2013-05-22 08:25:31 UTC) #2
Nils Barth (inactive)
On 2013/05/22 08:25:31, slightlyoff wrote: > Have you verified that npchrome_frame.dll still links with this ...
7 years, 7 months ago (2013-05-22 08:34:48 UTC) #3
slightlyoff
Robert would know, but I can try this change for you later today. On 22 ...
7 years, 7 months ago (2013-05-22 09:10:23 UTC) #4
Nils Barth (inactive)
On 2013/05/22 09:10:23, slightlyoff wrote: > Robert would know, but I can try this change ...
7 years, 7 months ago (2013-05-22 10:26:52 UTC) #5
grt (UTC plus 2)
On 2013/05/22 08:34:48, Nils Barth wrote: > On 2013/05/22 08:25:31, slightlyoff wrote: > > Have ...
7 years, 7 months ago (2013-05-22 12:57:59 UTC) #6
slightlyoff
Links fine. LGTM++ On 2013/05/22 12:57:59, grt wrote: > On 2013/05/22 08:34:48, Nils Barth wrote: ...
7 years, 7 months ago (2013-05-22 13:04:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/15679004/1
7 years, 7 months ago (2013-05-23 02:12:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/15679004/22001
7 years, 7 months ago (2013-05-23 02:27:53 UTC) #9
commit-bot: I haz the power
7 years, 7 months ago (2013-05-23 13:11:06 UTC) #10
Message was sent while issue was closed.
Change committed as 201779

Powered by Google App Engine
This is Rietveld 408576698