Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 15675007: Suppressed resizing when the preview panel shows and hides. (Closed)

Created:
7 years, 6 months ago by hirono
Modified:
7 years, 6 months ago
Reviewers:
mtomasz, yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Suppressed resizing when the preview panel shows and hides. Currently preview panel is transparent and does not affect the size of other components. Thus this CL just removed call for onResize. This CL also removes unused function requestResize. BUG=238867 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203076

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed a unused variable. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M chrome/browser/resources/file_manager/js/file_manager.js View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_selection.js View 1 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hirono
Could you check this CL? Thank you!
7 years, 6 months ago (2013-05-29 06:21:03 UTC) #1
yoshiki
lgtm. Thanks for cleaning up!
7 years, 6 months ago (2013-05-29 06:38:58 UTC) #2
mtomasz
On 2013/05/29 06:38:58, yoshiki wrote: > lgtm. Thanks for cleaning up! lgtm. That fm.onResize_ (calling ...
7 years, 6 months ago (2013-05-29 06:41:12 UTC) #3
yoshiki
a nit comment. https://codereview.chromium.org/15675007/diff/1/chrome/browser/resources/file_manager/js/file_selection.js File chrome/browser/resources/file_manager/js/file_selection.js (left): https://codereview.chromium.org/15675007/diff/1/chrome/browser/resources/file_manager/js/file_selection.js#oldcode325 chrome/browser/resources/file_manager/js/file_selection.js:325: var fm = this.fileManager_; nit: You ...
7 years, 6 months ago (2013-05-29 07:09:38 UTC) #4
hirono
On 2013/05/29 07:09:38, yoshiki wrote: > a nit comment. > > https://codereview.chromium.org/15675007/diff/1/chrome/browser/resources/file_manager/js/file_selection.js > File chrome/browser/resources/file_manager/js/file_selection.js ...
7 years, 6 months ago (2013-05-30 02:16:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/15675007/6001
7 years, 6 months ago (2013-05-30 02:16:33 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-05-30 05:01:21 UTC) #7
Message was sent while issue was closed.
Change committed as 203076

Powered by Google App Engine
This is Rietveld 408576698