Try to read the stdout pipe to the Valgrind process differently

Try to read the stdout pipe to the Valgrind process differently
Should fix reliability_tests under Valgrind

BUG=163314
TBR=glider@chromium.org
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202523

[Timur Iskhodzhanov, 2013-05-28 09:47:53]

TBR

[commit-bot: I haz the power, 2013-05-28 09:48:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timurrrr@chromium.org/15675005/1

[commit-bot: I haz the power, 2013-05-28 10:43:56]

Change committed as 202523

[Reid Kleckner, 2013-05-28 13:00:27]

LGTM

https://chromiumcodereview.appspot.com/15675005/diff/1/tools/valgrind/common.py
File tools/valgrind/common.py (right):

https://chromiumcodereview.appspot.com/15675005/diff/1/tools/valgrind/common....
tools/valgrind/common.py:88: sys.stdout.flush()
Aha.  :)  Is that it?

[Reid Kleckner, 2013-05-28 13:01:34]

https://chromiumcodereview.appspot.com/15675005/diff/1/tools/valgrind/common.py
File tools/valgrind/common.py (right):

https://chromiumcodereview.appspot.com/15675005/diff/1/tools/valgrind/common....
tools/valgrind/common.py:88: sys.stdout.flush()
On 2013/05/28 13:00:27, Reid Kleckner wrote:
> Aha.  :)  Is that it?

Er, no, it shouldn't be.

[Timur Iskhodzhanov, 2013-05-28 13:01:57]

https://chromiumcodereview.appspot.com/15675005/diff/1/tools/valgrind/common.py
File tools/valgrind/common.py (right):

https://chromiumcodereview.appspot.com/15675005/diff/1/tools/valgrind/common....
tools/valgrind/common.py:88: sys.stdout.flush()
Nope, I don't think so - the hangs happen when python is around line 62 [old
line 58].

[Nico, 2013-07-15 17:16:35]

https://chromiumcodereview.appspot.com/15675005/diff/1/tools/valgrind/common.py
File tools/valgrind/common.py (right):

https://chromiumcodereview.appspot.com/15675005/diff/1/tools/valgrind/common....
tools/valgrind/common.py:59: while line and not did_timeout:
Since this makes a difference and is very non-obvious, having a comment that
explains why this is a while and not a for-in loop might be a good idea.

[Timur Iskhodzhanov, 2013-07-15 18:18:42]

https://chromiumcodereview.appspot.com/15675005/diff/1/tools/valgrind/common.py
File tools/valgrind/common.py (right):

https://chromiumcodereview.appspot.com/15675005/diff/1/tools/valgrind/common....
tools/valgrind/common.py:59: while line and not did_timeout:
On 2013/07/15 17:16:35, Nico wrote:
> Since this makes a difference and is very non-obvious, having a comment that
> explains why this is a while and not a for-in loop might be a good idea.

That was done in r202841 when I actually became sure WTH is going on.

[Nico, 2013-07-15 18:20:30]

On Mon, Jul 15, 2013 at 11:18 AM, <timurrrr@chromium.org> wrote:

>
> https://chromiumcodereview.**appspot.com/15675005/diff/1/**
>
tools/valgrind/common.py<https://chromiumcodereview.appspot.com/15675005/diff/1/tools/valgrind/common.py>
> File tools/valgrind/common.py (right):
>
> https://chromiumcodereview.**appspot.com/15675005/diff/1/**
>
tools/valgrind/common.py#**newcode59<https://chromiumcodereview.appspot.com/15675005/diff/1/tools/valgrind/common.py#newcode59>
> tools/valgrind/common.py:59: while line and not did_timeout:
> On 2013/07/15 17:16:35, Nico wrote:
>
>> Since this makes a difference and is very non-obvious, having a
>>
> comment that
>
>> explains why this is a while and not a for-in loop might be a good
>>
> idea.
>
> That was done in r202841 when I actually became sure WTH is going on.
>

Awesome, thanks!

Sorry for the zombie review comment.


>
>
https://chromiumcodereview.**appspot.com/15675005/<https://chromiumcodereview...
>